From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuPF2-00041C-Mn for qemu-devel@nongnu.org; Fri, 28 Nov 2014 12:22:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XuPEw-0003gg-Gl for qemu-devel@nongnu.org; Fri, 28 Nov 2014 12:22:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XuPEw-0003gL-8s for qemu-devel@nongnu.org; Fri, 28 Nov 2014 12:21:54 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sASHLqwD005453 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 28 Nov 2014 12:21:52 -0500 Message-ID: <5478AF2A.3090804@redhat.com> Date: Fri, 28 Nov 2014 18:21:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1416227466-29491-1-git-send-email-mreitz@redhat.com> <8738931fr3.fsf@blackfin.pond.sub.org> In-Reply-To: <8738931fr3.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/3] chardev: Add -qmp-pretty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi , Luiz Capitulino On 28/11/2014 16:55, Markus Armbruster wrote: > Copying Luiz. > > Max Reitz writes: > >> This series does not add new functionality. Adding a QMP monitor with >> prettily formatted JSON output can be done as follows: >> >> $ qemu -chardev stdio,id=mon0 -mon chardev=mon0,mode=control,pretty=on >> >> However, this is rather cumbersome, so this series (its first patch) >> adds a shortcut in the form of the new command line option -qmp-pretty. >> >> Since the argument given to a monitor command line option (such as -qmp) >> is parsed depending on its prefix and probably also depending on the >> current phase of the moon, this is cleaner than trying to add a "switch" >> to -qmp itself (in the form of "-qmp stdio,pretty=on"). > > Yet another "convenience" option *groan* > > Why can't we simply make -qmp set pretty=on and be done with it? > It's a convenience option, i.e. meant for humans, and why would humans > *not* want pretty=on? Agreed, it is valid JSON anyway so there is no backwards compatibility issue. Paolo