From: Peter Lieven <pl@kamp.de>
To: Paolo Bonzini <pbonzini@redhat.com>,
ming.lei@canonical.com, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/3] qemu-coroutine: use a ring per thread for the pool
Date: Fri, 28 Nov 2014 21:11:48 +0100 [thread overview]
Message-ID: <5478D704.4090206@kamp.de> (raw)
In-Reply-To: <547883E9.2080004@redhat.com>
Am 28.11.2014 um 15:17 schrieb Paolo Bonzini:
>
> On 28/11/2014 14:17, Peter Lieven wrote:
>>>>>> The release_pool is not cleanup up on termination I think.
>>>> That's not necessary, it is global.
>> I don't see where you iterate over release_pool and destroy all coroutines?
> The OS does that for us when we exit.
Sure, but isn't that considered bad practice?
Before this patch the destructured freed the coroutines.
Peter
next prev parent reply other threads:[~2014-11-28 20:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 10:27 [Qemu-devel] [RFC PATCH 0/3] qemu-coroutine: use a ring per thread for the pool Peter Lieven
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 1/3] Revert "coroutine: make pool size dynamic" Peter Lieven
2014-11-28 12:42 ` Stefan Hajnoczi
2014-11-28 12:45 ` Peter Lieven
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 2/3] block/block-backend.c: remove coroutine pool reservation Peter Lieven
2014-11-27 10:27 ` [Qemu-devel] [RFC PATCH 3/3] qemu-coroutine: use a ring per thread for the pool Peter Lieven
2014-11-27 16:40 ` Paolo Bonzini
2014-11-28 8:13 ` Peter Lieven
[not found] ` <54784E55.6060405@redhat.com>
2014-11-28 10:37 ` Peter Lieven
2014-11-28 11:14 ` Paolo Bonzini
2014-11-28 11:21 ` Peter Lieven
2014-11-28 11:23 ` Paolo Bonzini
2014-11-28 11:27 ` Peter Lieven
2014-11-28 11:32 ` Peter Lieven
2014-11-28 11:46 ` Peter Lieven
2014-11-28 12:26 ` Paolo Bonzini
2014-11-28 12:39 ` Peter Lieven
2014-11-28 12:45 ` Paolo Bonzini
2014-11-28 12:49 ` Peter Lieven
2014-11-28 12:56 ` Paolo Bonzini
2014-11-28 13:17 ` Peter Lieven
2014-11-28 14:17 ` Paolo Bonzini
2014-11-28 20:11 ` Peter Lieven [this message]
2014-11-28 13:13 ` Peter Lieven
2014-11-28 12:21 ` Paolo Bonzini
2014-11-28 12:26 ` Peter Lieven
2014-11-28 12:40 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5478D704.4090206@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).