From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41063)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XuRtu-0006Q4-BB
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 15:12:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1XuRtk-0004vJ-IM
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 15:12:22 -0500
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:53978 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XuRtZ-0004sW-UE
	for qemu-devel@nongnu.org; Fri, 28 Nov 2014 15:12:12 -0500
Message-ID: <5478D704.4090206@kamp.de>
Date: Fri, 28 Nov 2014 21:11:48 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1417084026-12307-1-git-send-email-pl@kamp.de>	<1417084026-12307-4-git-send-email-pl@kamp.de>	<547753F7.2030709@redhat.com>
	<54782EC3.10005@kamp.de>	<54784E55.6060405@redhat.com>
	<54785067.60905@kamp.de>	<547858FF.5070602@redhat.com>
	<54785AA5.9070409@kamp.de>	<54785B2E.9070203@redhat.com>
	<54785D60.1070306@kamp.de>	<5478609B.8060503@kamp.de>
	<547869DE.3080907@redhat.com>	<54786CF5.2060705@kamp.de>
	<54786E52.6050209@redhat.com> <547875CF.8000207@kamp.de>
	<547883E9.2080004@redhat.com>
In-Reply-To: <547883E9.2080004@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 3/3] qemu-coroutine: use a ring per
 thread for the pool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, ming.lei@canonical.com, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

Am 28.11.2014 um 15:17 schrieb Paolo Bonzini:
>
> On 28/11/2014 14:17, Peter Lieven wrote:
>>>>>>  The release_pool is not cleanup up on termination I think.
>>>> That's not necessary, it is global.
>> I don't see where you iterate over release_pool and destroy all coroutines?
> The OS does that for us when we exit.

Sure, but isn't that considered bad practice?
Before this patch the destructured freed the coroutines.

Peter