From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xuj18-00013c-S2 for qemu-devel@nongnu.org; Sat, 29 Nov 2014 09:29:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xuj0z-0007YP-Sf for qemu-devel@nongnu.org; Sat, 29 Nov 2014 09:28:58 -0500 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:59819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xuj0z-0007YI-LQ for qemu-devel@nongnu.org; Sat, 29 Nov 2014 09:28:49 -0500 Received: by mail-wg0-f48.google.com with SMTP id y19so10731379wgg.7 for ; Sat, 29 Nov 2014 06:28:49 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5479D81D.30706@redhat.com> Date: Sat, 29 Nov 2014 15:28:45 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417183941-26329-1-git-send-email-pbonzini@redhat.com> <1417183941-26329-8-git-send-email-pbonzini@redhat.com> <5478E0A5.6060405@kamp.de> In-Reply-To: <5478E0A5.6060405@kamp.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/7] coroutine: try harder not to delete coroutines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, ming.lei@canonical.com, stefanha@redhat.com On 28/11/2014 21:52, Peter Lieven wrote: >> > + alloc_pool_size += atomic_xchg(&release_pool_size, 0); > I had alloc_pool_size = in my original Patch. > It shouldn't make a difference, since alloc_pool_size should be 0 > when we reach this code piece. But if for some reason release_pool_size > is inaccurate we add this error to alloc_pool_size again and again > and eventually end up not adding coroutines to the thread local pool below > altough it might be empty in the worst case. Oops, this must come from a rebase. Thanks for pointing it out. Paolo