From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvTPm-0002RO-04 for qemu-devel@nongnu.org; Mon, 01 Dec 2014 11:01:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvTPg-0005ZC-SQ for qemu-devel@nongnu.org; Mon, 01 Dec 2014 11:01:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvTPg-0005Z5-Ij for qemu-devel@nongnu.org; Mon, 01 Dec 2014 11:01:24 -0500 Message-ID: <547C90CD.2010005@redhat.com> Date: Mon, 01 Dec 2014 09:01:17 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417099720-16428-1-git-send-email-mreitz@redhat.com> <1417099720-16428-3-git-send-email-mreitz@redhat.com> In-Reply-To: <1417099720-16428-3-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bQFHjgBwMM2RiAPXatxnXXa1lmOWcg9KK" Subject: Re: [Qemu-devel] [PATCH v2 02/13] block: Omit bdrv_find_format for essential drivers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Lieven , Markus Armbruster , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bQFHjgBwMM2RiAPXatxnXXa1lmOWcg9KK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/27/2014 07:48 AM, Max Reitz wrote: > We can always assume raw, file and qcow2 being available; so do not use= > bdrv_find_format() to locate their BlockDriver objects but statically > reference the respective objects. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Max Reitz > --- > block.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) Reviewed-by: Eric Blake > @@ -1293,7 +1288,6 @@ int bdrv_append_temp_snapshot(BlockDriverState *b= s, int flags, Error **errp) > /* TODO: extra byte is a hack to ensure MAX_PATH space on Windows.= */ > char *tmp_filename =3D g_malloc0(PATH_MAX + 1); > int64_t total_size; > - BlockDriver *bdrv_qcow2; Hmm - how hard would it be to get qemu to be clean under -Wshadow? This is a case where you would have had to change this hunk during patch 1 if -Wshadow were in effect. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bQFHjgBwMM2RiAPXatxnXXa1lmOWcg9KK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUfJDNAAoJEKeha0olJ0Nq5EMH/0bbAyR+4BYVn4uybDPUt6eP NjwaVfVog7bT0dOu0VY526JALzIHmfLpFBWPJAAS2W7db/KY0UazdbRg+KXTW74O IxZfZRXwPIPTGuReyaDaeP2H75W+Afry1ia4voatEnscxRhcNHuxTcb5N/e6mIF7 zwA4/VbVY0bmZRTXLxFe1+9FypAEKIKpDrvv/IrNZDraMHtmnGtjePrCWuvVwSEW LxN7+Y/hyaEGUE9fHgvHPw+Msr+bhl6JJd5agPXJgsyyZhL9SjAurFVej/DLKa37 fTeE1AsPfJTItDVtxli0CbZDq353xGjnBE3CdIBRqDcluRdoWKnJu3OBr4eCT+E= =4QbT -----END PGP SIGNATURE----- --bQFHjgBwMM2RiAPXatxnXXa1lmOWcg9KK--