From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvXju-0005RI-9h for qemu-devel@nongnu.org; Mon, 01 Dec 2014 15:38:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvXjo-0004HJ-5J for qemu-devel@nongnu.org; Mon, 01 Dec 2014 15:38:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvXjn-0004Gs-Tx for qemu-devel@nongnu.org; Mon, 01 Dec 2014 15:38:28 -0500 Message-ID: <547CD1C1.5000102@redhat.com> Date: Mon, 01 Dec 2014 13:38:25 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417465816-19345-1-git-send-email-jsnow@redhat.com> <1417465816-19345-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1417465816-19345-2-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="g2pICFwtpFdQklWbVhUC1q1grTAaxH3Nm" Subject: Re: [Qemu-devel] [PATCH v9 01/10] qapi: Add optional field "name" to block dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g2pICFwtpFdQklWbVhUC1q1grTAaxH3Nm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/01/2014 01:30 PM, John Snow wrote: > From: Fam Zheng >=20 > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap with a common name. >=20 > Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will= > be used later when other QMP commands want to reference dirty bitmap by= > name. >=20 > Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. >=20 > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block-migration.c | 2 +- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 2 +- > include/block/block.h | 7 ++++++- > qapi/block-core.json | 4 +++- > 5 files changed, 42 insertions(+), 5 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --g2pICFwtpFdQklWbVhUC1q1grTAaxH3Nm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUfNHBAAoJEKeha0olJ0NqGSQH/0fP4nO4Oy/AxJr1XLLrrN3E mUvNfElXblqbIaFsocioJRDTFh2n1mRhWUybLq7oFz2O+7WTkvYYFBKoX9TinLmw prCgRStE6p3947r+e17WObIOcBKZmJSfIULf8zHhfC9PhBSfGZg3jtGZO9IIZbrq lrgPdthuh6YuJoeR2Stk7AJVuw1QXUWWK9gYjz1lHxbsXdw4gdft9CYpVU+dGdAC 8a/VUJz7eFpLRonPos71q9u/Wq3U5M2E1FdCXvX3PhhlpYuJ4ErIcDXMVLlwdr3a vYfqFahW70YGOEaafxzwuxQinT/yCu1a4N7BLf734MIKPLDAtVFJSd8kHyErpO0= =bxUL -----END PGP SIGNATURE----- --g2pICFwtpFdQklWbVhUC1q1grTAaxH3Nm--