From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvYjb-00030x-C8 for qemu-devel@nongnu.org; Mon, 01 Dec 2014 16:42:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvYjW-0001yc-Ex for qemu-devel@nongnu.org; Mon, 01 Dec 2014 16:42:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvYjW-0001yJ-7h for qemu-devel@nongnu.org; Mon, 01 Dec 2014 16:42:14 -0500 Message-ID: <547CE0B2.6040306@redhat.com> Date: Mon, 01 Dec 2014 14:42:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417465816-19345-1-git-send-email-jsnow@redhat.com> <1417465816-19345-3-git-send-email-jsnow@redhat.com> In-Reply-To: <1417465816-19345-3-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kDXHuvNbpaC2elGTHHBqHPbFMKro5VjDe" Subject: Re: [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kDXHuvNbpaC2elGTHHBqHPbFMKro5VjDe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/01/2014 01:30 PM, John Snow wrote: > From: Fam Zheng >=20 > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device= , > but different devices can have bitmaps with the same names. >=20 > The granularity is an optional field. If it is not specified, we will > choose a default granularity based on the cluster size if available, > clamped to between 4K and 64K to mirror how the 'mirror' code was > already choosing granularity. If we do not have cluster size info > available, we choose 64K. This code has been factored out into a helper= > shared with block/mirror. >=20 > The types added to block-core.json will be re-used in future patches > in this series, see: > 'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disa= ble}' >=20 > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > +block-dirty-bitmap-add > +---------------------- > + > +Create a dirty bitmap with a name on the device, and start tracking th= e writes. > + > +Arguments: > + > +- "device": device name to create dirty bitmap (json-string) > +- "name": name of the new dirty bitmap (json-string) > +- "granularity": granularity to track writes with (int) Worth mentioning that this is optional? Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kDXHuvNbpaC2elGTHHBqHPbFMKro5VjDe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUfOCyAAoJEKeha0olJ0Nqc50IAK21zCBT0iqzDQcrpOcwVPws kL9Xz4DRR/Vvag9fqK5jkq61BDfwALNrRseOh7dxyr6dtrEIrxwSTpHqipnnTJ+5 KjGEDD0sJyR77quhUJRL9TweTgs1zpwe2Hpxl7M33BQVNiuxhHY2q4J7tU4DsDVz k6gnm1KyUoQ7Q7r5M1lkSeQ7xO2yb8i+34VpmP7fD6B1xslbpAp8TIo9aJPdlIsf cahJIs7TJggVRv7PteqHfH3BdFduSjyLbld3l5BV3JYUo1ZvpaABvFdCB7z5Ej/I P8Z5wmS6mTkfO885AMplw+nMTadmtUHm994frUBCp8hDhNdKQKHl0JVaXiJ1y8s= =HsUj -----END PGP SIGNATURE----- --kDXHuvNbpaC2elGTHHBqHPbFMKro5VjDe--