From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvZBJ-00036R-41 for qemu-devel@nongnu.org; Mon, 01 Dec 2014 17:11:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvZBE-0006WR-Qt for qemu-devel@nongnu.org; Mon, 01 Dec 2014 17:10:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvZBE-0006Vy-Hu for qemu-devel@nongnu.org; Mon, 01 Dec 2014 17:10:52 -0500 Message-ID: <547CE768.9050405@redhat.com> Date: Mon, 01 Dec 2014 15:10:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416991272-10277-1-git-send-email-bdpayne@acm.org> <1417033667-10364-1-git-send-email-bdpayne@acm.org> <1417033667-10364-2-git-send-email-bdpayne@acm.org> In-Reply-To: <1417033667-10364-2-git-send-email-bdpayne@acm.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nCTFHxJHkiX877XRbdhFML4PdB5cCTmX0" Subject: Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Bryan D. Payne" , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nCTFHxJHkiX877XRbdhFML4PdB5cCTmX0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/26/2014 01:27 PM, Bryan D. Payne wrote: > This patch adds a new QMP command that sets up a domain socket. This > socket can then be used for fast read/write access to the guest's > physical memory. The key benefit to this system over existing solutions= > is speed. Using this patch, guest memory can be copied out at a rate of= > ~200MB/sec, depending on the hardware. Existing solutions only achieve > a small fraction of this speed. >=20 > Signed-off-by: Bryan D. Payne > + > +## > +# @pmemaccess > +# > +# This command enables access to guest physical memory using > +# a simple protocol over a UNIX domain socket. > +# > +# @path Location to use for the UNIX domain socket > +# > +# Since: 2.3 > +## > +{ 'command': 'pmemaccess', 'data': { 'path': 'str' } } In addition to Fam's review, I have a question - does this code properly use qemu_open() so that I can use 'add-fd' to pass in a pre-opened socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If not, can you please fix it to allow this usage? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nCTFHxJHkiX877XRbdhFML4PdB5cCTmX0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUfOdoAAoJEKeha0olJ0Nq6TMH/RYw3AqfaVCqDQrpqwEee0V3 +ig/Op8dbOnBGbFqe90HX3ioOcgfk1w4GVpBf2i6n+Z9OLt+YDR7q9EVRgOX1I8m 0taRCpjdYL+wYdZ5rCVVdTgbKlHb+tWtLSDl//Nsy8tZe0L5j33LeIdQe26OSHCe IFLfi67LF4UXFShf+Bz05NHeDaXLv3ZiroIX9kinUmDhg33Mml5Z2FeaICUC1yVN SygduDUJd/qrETAUG4SClewh4pq+Oesbrb76vB0gTyepm/YOHDlE846Tn9PskO73 dr+vUIj+fHTvFalvko3/RptBWwfHPQU77xym2OsRoVvdzShqLFxnmsuIAcD4D9A= =6sjT -----END PGP SIGNATURE----- --nCTFHxJHkiX877XRbdhFML4PdB5cCTmX0--