From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52520)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XvkBq-0007q7-IU
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 04:56:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XvkBk-000217-FF
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 04:56:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56819)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XvkBk-000213-7z
	for qemu-devel@nongnu.org; Tue, 02 Dec 2014 04:56:08 -0500
Message-ID: <547D8CB3.7030600@redhat.com>
Date: Tue, 02 Dec 2014 10:56:03 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1416503198-17031-1-git-send-email-mreitz@redhat.com>
	<1416503198-17031-11-git-send-email-mreitz@redhat.com>
	<20141127162509.GJ15586@stefanha-thinkpad.lan>
In-Reply-To: <20141127162509.GJ15586@stefanha-thinkpad.lan>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 10/22] qcow2: refcount_order parameter
 for qcow2_create2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-11-27 at 17:25, Stefan Hajnoczi wrote:
> On Thu, Nov 20, 2014 at 06:06:26PM +0100, Max Reitz wrote:
>> @@ -2003,6 +2015,7 @@ static int qcow2_create(const char *filename, QemuOpts *opts, Error **errp)
>>       size_t cluster_size = DEFAULT_CLUSTER_SIZE;
>>       PreallocMode prealloc;
>>       int version = 3;
>> +    int refcount_width = 16, refcount_order;
> It would be nice to consistently use either refcount_width or
> refcount_bits throughout the code.

Will (try to) use refcount_bits everywhere.

Max