From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvkn6-0003lY-HY for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:34:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xvkmy-0007B9-KY for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:34:44 -0500 Received: from mx2.parallels.com ([199.115.105.18]:41875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xvkmy-0006yf-Er for qemu-devel@nongnu.org; Tue, 02 Dec 2014 05:34:36 -0500 Message-ID: <547D9584.7060901@openvz.org> Date: Tue, 2 Dec 2014 13:33:40 +0300 From: "Denis V. Lunev" MIME-Version: 1.0 References: <1415278478-19384-1-git-send-email-den@openvz.org> In-Reply-To: <1415278478-19384-1-git-send-email-den@openvz.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/7] parallels format support improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Jeff Cody , qemu-devel@nongnu.org, Stefan Hajnoczi , Roman Kagan On 06/11/14 15:54, Denis V. Lunev wrote: > The patchset implements additional compatibility bits for Parallels > format: > - initial support of parsing of Parallels DiskDeskriptor.xml > Typically Parallels disk bundle consists of several images which are > glued by XML disk descriptor. Also XML hides inside several important > parameters which are not available in the image header. > - support for padded Parallels images. > For the time being Parallels was created an optimization for such OSes > in its desktop product. Desktop users are not qualified enough to create > properly aligned installations. Thus Parallels makes a blind guess > on a customer behalf and creates so-called "padded" images if guest > OS type is specified as WinXP, Win2k and Win2k3. > > The code uses approach from VMDK support, either image or XML descriptor > could be used. Though there is temporary hack in the opening code: > BlockDriverState->file is being reopened inside parallels_open. I prefer > to keep this code in this state till proper Parallels snapshots support > in order to minimize current changes. > > Changes from v2: > - (patch 1) changed libxml2 addition as suggested by Michael Tokarev > - (patch 2) changed API of xml_find/xml_get_text to avoid memcpy to variable > on stack > - (patch 2) dropped predefined value for PARALLELS_XML/PARALLELS_IMAGE > - (patch 2) other minor changes (spelling, placement) > - (patch 3) quoted TEST_IMG as suggested by Jeff Cody > - (patches 4, 6) quoted TEST_IMG as suggested by Jeff Cody > > Changes from v1: > - dropped already merged part (original patches 1-3) > > CC: Jeff Cody > CC: Kevin Wolf > CC: Stefan Hajnoczi > CC: Roman Kagan > CC: Denis V. Lunev > ping