From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33299)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xw5Kf-0007ic-EE
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 03:30:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xw5Ka-0008FG-KV
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 03:30:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54642)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Xw5Ka-0008F8-DB
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 03:30:40 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB38Uds9005475
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 3 Dec 2014 03:30:39 -0500
Message-ID: <547ECA2C.8000107@redhat.com>
Date: Wed, 03 Dec 2014 09:30:36 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1417571370-19495-1-git-send-email-famz@redhat.com>
In-Reply-To: <1417571370-19495-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Skip 099 for VMDK subformats
 with desc file
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-12-03 at 02:49, Fam Zheng wrote:
> VMDK extent parsing code doesn't handle the JSON file name, so the case
> fails for these subformats. Disabled them.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   tests/qemu-iotests/099 | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/099 b/tests/qemu-iotests/099
> index ffc7ea7..fb920fe 100755
> --- a/tests/qemu-iotests/099
> +++ b/tests/qemu-iotests/099
> @@ -44,7 +44,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>   _supported_fmt qcow qcow2 qed vdi vhdx vmdk vpc
>   _supported_proto file
>   _supported_os Linux
> -
> +_unsupported_imgopts "subformat=monolithicFlat" "subformat=twoGbMaxExtentFlat" \
> +    "subformat=twoGbMaxExtentSparse"
>   
>   function do_run_qemu()
>   {

This is most certainly necessary, therefore: Thanks, applied to my 
block-next tree:

https://github.com/XanClic/qemu/commits/block-next

However, as I said in our private email exchange, we need to fix the 
error message, too.

$ qemu-img create -f vmdk -o subformat=monolithicFlat test.vmdk 64M
Formatting 'test.vmdk', fmt=vmdk size=67108864 compat6=off 
subformat='monolithicFlat'
$ qemu-io -c 'open -o 
file.driver=blkdebug,file.image.filename=test.vmdk,file.inject-error.0.event=read_aio' 

qemu-io: can't open: Could not parse the JSON options

That's not very helpful. I'll send a patch for that.

Max