From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XwAef-0000XV-Sk
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:11:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XwAeZ-0008Vo-Ov
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:11:45 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56589)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XwAeZ-0008Va-BM
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:11:39 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3EBcIZ010704
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 3 Dec 2014 09:11:38 -0500
Message-ID: <547F1A17.1040701@redhat.com>
Date: Wed, 03 Dec 2014 15:11:35 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1417602521-14482-1-git-send-email-famz@redhat.com>
	<1417602521-14482-2-git-send-email-famz@redhat.com>
In-Reply-To: <1417602521-14482-2-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate
 CID
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-12-03 at 11:28, Fam Zheng wrote:
> This replaces two "time(NULL)" invocations with "g_random_int()".
> According to VMDK spec, CID "is a random 32=E2=80=90bit value updated t=
he first
> time the content of the virtual disk is modified after the virtual disk
> is opened". Using "seconds since epoch" is just a "lame way" to generat=
e
> it, and not completely safe because of the low precision.
>
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> ---
>   block/vmdk.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 2cbfd3e..ebb4b70 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -28,6 +28,7 @@
>   #include "qemu/module.h"
>   #include "migration/migration.h"
>   #include <zlib.h>
> +#include <glib.h>

This should be covered by qemu-common.h already. But anyway:

Reviewed-by: Max Reitz <mreitz@redhat.com>