From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwAgo-0002KZ-83 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:14:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwAgh-0000c5-VG for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:13:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46406) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwAgh-0000c0-MZ for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:13:51 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3EDpNf007170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 09:13:51 -0500 Message-ID: <547F1A9C.8040108@redhat.com> Date: Wed, 03 Dec 2014 15:13:48 +0100 From: Max Reitz MIME-Version: 1.0 References: <1417602521-14482-1-git-send-email-famz@redhat.com> <1417602521-14482-3-git-send-email-famz@redhat.com> In-Reply-To: <1417602521-14482-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/6] vmdk: Fix comment to match code of extent lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi On 2014-12-03 at 11:28, Fam Zheng wrote: > commit 04d542c8b (vmdk: support vmfs files) added support of VMFS extent > type but the comment above the changed code is left out. Update the > comment so they are consistent. > > Signed-off-by: Fam Zheng > Reviewed-by: Markus Armbruster > --- > block/vmdk.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/block/vmdk.c b/block/vmdk.c > index ebb4b70..28d22db 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -785,10 +785,11 @@ static int vmdk_parse_extents(const char *desc, BlockDriverState *bs, > VmdkExtent *extent; > > while (*p) { > - /* parse extent line: > + /* parse extent line in one of below formats: > + * > * RW [size in sectors] FLAT "file-name.vmdk" OFFSET > - * or > * RW [size in sectors] SPARSE "file-name.vmdk" > + * RW [size in sectors] VMFS "file-name.vmdk" > */ > flat_offset = -1; > ret = sscanf(p, "%10s %" SCNd64 " %10s \"%511[^\n\r\"]\" %" SCNd64, Isn't VMFSSPARSE missing? It doesn't seem to be handled any different than SPARSE, but then again, VMFS isn't handled so differently than FLAT either (except it doesn't take an offset)... Max