From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55485)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XwAtN-0002Pe-Jq
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:27:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XwAtG-00056q-4w
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:26:57 -0500
Received: from cantor2.suse.de ([195.135.220.15]:55047 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XwAtF-00056Q-UU
	for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:26:50 -0500
Message-ID: <547F1DA5.9090506@suse.de>
Date: Wed, 03 Dec 2014 15:26:45 +0100
From: =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1417604616-6289-1-git-send-email-paul.durrant@citrix.com>
	<1417604616-6289-2-git-send-email-paul.durrant@citrix.com>
	<alpine.DEB.2.02.1412031228081.30971@kaball.uk.xensource.com>
In-Reply-To: <alpine.DEB.2.02.1412031228081.30971@kaball.uk.xensource.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 REPOST 1/2] Add device listener interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Paul Durrant <paul.durrant@citrix.com>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Thomas Huth <thuth@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Am 03.12.2014 um 13:29 schrieb Stefano Stabellini:
> The second patch is already Acked.
> You just need a review on this one to move forward, right?
>=20
> Andreas, Michael?

Once again, I would appreciate if such patches consistently used device_
/ DEVICE_ rather than qdev_ / QDEV_. In particular given that
DeviceListener is being used already and this doesn't seem to rely on
old qdev. But other than that no objections. Will be back in the office
next week.

Regards,
Andreas

--=20
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 21284 AG N=FCrnbe=
rg