From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59948) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBBE-0007uA-Ps for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:45:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwBB8-0003cv-LI for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:45:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBB8-0003Zo-Cx for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:45:18 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3EjGmo021373 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 09:45:17 -0500 Message-ID: <547F21FB.1050009@redhat.com> Date: Wed, 03 Dec 2014 09:45:15 -0500 From: John Snow MIME-Version: 1.0 References: <1417610103-18234-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1417610103-18234-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 12/03/2014 07:35 AM, Kevin Wolf wrote: > Our IDE emulation can't handle logical block sizes other than 512. Check > for it. > > The original assumption was that other values would silently be ignored > (which is bad enough), but it's not quite true: The physical block size > is exposed in IDENTIFY DEVICE as a multiple of the logical block size. > Setting a logical block size therefore also corrupts the physical block > size (4096/4096 doesn't silently downgrade to 4096/512, but 512/512). > > Signed-off-by: Kevin Wolf > --- > hw/ide/qdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c > index b4f096e..1ebb58d 100644 > --- a/hw/ide/qdev.c > +++ b/hw/ide/qdev.c > @@ -163,6 +163,11 @@ static int ide_dev_initfn(IDEDevice *dev, IDEDriveKind kind) > return -1; > } > > + if (dev->conf.logical_block_size != 512) { > + error_report("logical_block_size must be 512 for IDE"); > + return -1; > + } > + > blkconf_serial(&dev->conf, &dev->serial); > if (kind != IDE_CD) { > blkconf_geometry(&dev->conf, &dev->chs_trans, 65536, 16, 255, &err); > There are so many 512 literals in the IDE code that I actually assumed we already enforced this, or otherwise just always used 512 regardless. Reviewed-by: John Snow