From: Jiri Slaby <jslaby@suse.cz>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] pci-host: add educational driver
Date: Wed, 03 Dec 2014 16:11:32 +0100 [thread overview]
Message-ID: <547F2824.7080001@suse.cz> (raw)
In-Reply-To: <543BCCFC.6050904@redhat.com>
On 10/13/2014, 03:00 PM, Paolo Bonzini wrote:
>> +static void edu_dma_timer(void *opaque)
>> +{
>> + EduState *edu = opaque;
>> + bool raise_irq = false;
>> +
>> + qemu_mutex_lock(&edu->dma_mutex);
>
> dma_mutex and mutex and irq_mutex are not necessary. All I/O happens
> under the big QEMU lock (qemu_lock/unlock_iothread). I can certainly
> imagine that edu.c would be one of the first devices we make
> thread-safe, but... not yet. :)
Hi,
I finally got to it. I want to make sure that I understand this
correctly. So even timers are protected by the "BQL"?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2014-12-03 15:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 11:37 [Qemu-devel] [patch] qemu educational device Jiri Slaby
2014-10-10 11:49 ` Paolo Bonzini
2014-10-10 12:09 ` [Qemu-devel] [PATCH 1/1] pci-host: add educational driver Jiri Slaby
2014-10-10 14:54 ` Claudio Fontana
2014-10-13 8:32 ` Jiri Slaby
2014-10-13 13:02 ` Paolo Bonzini
2014-10-13 13:00 ` Paolo Bonzini
2014-12-03 15:11 ` Jiri Slaby [this message]
2014-12-03 15:18 ` Paolo Bonzini
2014-12-05 9:52 ` [Qemu-devel] [PATCH v2 " Jiri Slaby
2014-12-05 9:53 ` Jiri Slaby
2014-12-05 10:35 ` Paolo Bonzini
2014-12-05 11:45 ` Jiri Slaby
2014-12-05 12:07 ` Paolo Bonzini
2014-12-05 9:54 ` [Qemu-devel] [PATCH v3 " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F2824.7080001@suse.cz \
--to=jslaby@suse.cz \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).