From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBcB-0008FY-05 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:13:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwBc6-0003vo-18 for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:13:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBc5-0003vc-Pw for qemu-devel@nongnu.org; Wed, 03 Dec 2014 10:13:09 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3FD8pJ002576 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 10:13:09 -0500 Message-ID: <547F2884.1000001@redhat.com> Date: Wed, 03 Dec 2014 08:13:08 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-4-git-send-email-mreitz@redhat.com> In-Reply-To: <1417613866-25890-4-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8pTb01NLJgKkpUXHML81dcv5MbVNkguAa" Subject: Re: [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8pTb01NLJgKkpUXHML81dcv5MbVNkguAa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2014 06:37 AM, Max Reitz wrote: > qcow2_update_cluster_refcount() does not have any quick access to the > new refcount value, it has to call qcow2_get_refcount(). Some callers d= o > not need that new value at all, others call qcow2_get_refcount() > themselves anyway (albeit in a different code path, which can however b= e > easily changed), therefore there is no advantage in making > qcow2_update_cluster_refcount() return the new value. Drop it. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8pTb01NLJgKkpUXHML81dcv5MbVNkguAa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUfyiEAAoJEKeha0olJ0NqD8UIAKlr7ZNXdFPtoTdQ/qP5cLFp Smp93hp3Cp3+REjK584IDRsl8a0oQdrMdPUnLaiP+P9KUtQNFkAgcpYitxpKSatY hU5M1gONz/PF592u/52qt0cX9EWuwUfcm5GBC1FlMgc+3MP4U4j5KhjTxxC6dSeh 5JAd7EUGb8p6u/xdDXQN6eNA7aYR60P5KX/0XI5iW2e8q93zIVVlZUK1soV61PEH mgE8B4q32LlvAXH6PZp8XsBNwtGHrz6XJ6inEhQ9oSKElWXnUbssOyg6JJBSu1Po S5KMeG+tzozxEOZXOaFqDFRucVtBVGFEVL//jsiS9AnqnN0RleQ2Ppb9k4wOCIg= =PyVs -----END PGP SIGNATURE----- --8pTb01NLJgKkpUXHML81dcv5MbVNkguAa--