From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwDtb-0004x7-HW for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:39:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwDtX-0000XR-4v for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:39:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwDtW-0000XK-Ms for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:39:18 -0500 Message-ID: <547F4AB9.2000408@redhat.com> Date: Wed, 03 Dec 2014 10:39:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417530788-15172-1-git-send-email-pl@kamp.de> <1417530788-15172-2-git-send-email-pl@kamp.de> In-Reply-To: <1417530788-15172-2-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OWDblr8cgOvcnPnqQ9jQ5lcJXdv4HmAFE" Subject: Re: [Qemu-devel] [RFC PATCH 1/3] block: add accounting for merged requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OWDblr8cgOvcnPnqQ9jQ5lcJXdv4HmAFE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/02/2014 07:33 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block.c | 2 ++ > block/accounting.c | 7 +++++++ > block/qapi.c | 2 ++ > hmp.c | 6 +++++- > include/block/accounting.h | 3 +++ > qapi/block-core.json | 10 +++++++++- > 6 files changed, 28 insertions(+), 2 deletions(-) Incomplete. qmp-commands.hx includes a query-blockstats example that should be updated to show the output of the new non-optional fields. > +# @wr_merged: Number of write requests that have been merged into anot= her request Longer than 80 columns; please wrap. Otherwise looks good to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OWDblr8cgOvcnPnqQ9jQ5lcJXdv4HmAFE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUf0q5AAoJEKeha0olJ0NqJ8QH/R7r7FK5hX1XyQIvIlogqdCH QTFWdaUPMsxbXj7DM9dgrrrukqM4jZfT35no+oMYdKLONF6vQizHqUna6sZPC8BE kqwmb4VrmAwUePQXbKT66FdXvd6PtYzD1HBeGm6xetPdpj18ks8uvdUnz0QzZQUD gGRueHbQCwkVt78K84SM7dUkGFDl5KXlMxq1AnEfQrERzNoZDB8EGrAx7zdUTKwO r2mLKpSi03mDeWziE6xusvTmDVmhKIa71M5Be1vBlJ3sARQoDlO37bGcJh//XrAL ZfrvIfNJ/gOoJ2U3a9uju7KUyDsXx+7fOQ/J8vQwMi0RHtE5SrySw21/q41abL0= =Waif -----END PGP SIGNATURE----- --OWDblr8cgOvcnPnqQ9jQ5lcJXdv4HmAFE--