From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwDvz-0006Vo-Im for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:41:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwDvu-0001af-JA for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:41:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwDvu-0001aa-AI for qemu-devel@nongnu.org; Wed, 03 Dec 2014 12:41:46 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3HfjdF014406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 12:41:45 -0500 Message-ID: <547F4B58.4030303@redhat.com> Date: Wed, 03 Dec 2014 10:41:44 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-9-git-send-email-mreitz@redhat.com> In-Reply-To: <1417613866-25890-9-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="X6PXaDPqlDOTStbwp8BgJshOlfEXKkPs3" Subject: Re: [Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X6PXaDPqlDOTStbwp8BgJshOlfEXKkPs3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2014 06:37 AM, Max Reitz wrote: > qcow2_alloc_bytes() may reuse a cluster multiple times, in which case > the refcount is increased accordingly. However, if this would lead to a= n > overflow the function should instead just not reuse this cluster and > allocate a new one. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --X6PXaDPqlDOTStbwp8BgJshOlfEXKkPs3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUf0tYAAoJEKeha0olJ0NqriMIAIWd5F+hDZPM6B7zyhO6gMgl dH+6jHuYxu3+TDe5M2/M075vFbGT2iYiYtIG0W++kf5aObXarf8Xxu864F8BenMY Kq+8dl2xmivRsCtAbwN6Knbi15jNWy9zP3rSi3A0zWi7hpcCaVL5z4G68eWYA94G ccptv97F59vz84n7awl8pPUt1YZBWFCBcFSOqqsFfckFCrsXjVUoydp5DXI1l29z BzUfvg8Nm6WIchoorp/yknJ+bXqam4vd9H4jfWZ+XFrx9Z3OoHfL5KO5qa6EG0nB aDfXun59ULAT/byand9CmhD6SN43npyMMf5PhxMk9uqj3EUIsIj2Yyk0Y9t912M= =Pu1O -----END PGP SIGNATURE----- --X6PXaDPqlDOTStbwp8BgJshOlfEXKkPs3--