From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFc0-0004nU-FS for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:29:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwFbv-00079M-Hz for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:29:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36535) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFbv-00079E-8j for qemu-devel@nongnu.org; Wed, 03 Dec 2014 14:29:15 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3JTEkO025867 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 14:29:14 -0500 Message-ID: <547F6488.80006@redhat.com> Date: Wed, 03 Dec 2014 12:29:12 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-14-git-send-email-mreitz@redhat.com> In-Reply-To: <1417613866-25890-14-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jt6n3UW5ECtdQucOrlGAgQD5RLGviES2R" Subject: Re: [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jt6n3UW5ECtdQucOrlGAgQD5RLGviES2R Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2014 06:37 AM, Max Reitz wrote: > Add a refcount_order parameter to qcow2_create2(), use that value for > the image header and for calculating the size required for > preallocation. >=20 > For now, always pass 4. >=20 > This addition requires changes to the calculation of the file size for > the "full" and "falloc" preallocation modes. That in turn is a nice > opportunity to add a comment about that calculation not necessarily > being exact (and that being intentional). >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 46 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 35 insertions(+), 11 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jt6n3UW5ECtdQucOrlGAgQD5RLGviES2R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUf2SIAAoJEKeha0olJ0NqYvkH/RAExk7fJ9e917ViSJem4PSK ckkKcJykSoA5ZTl3Uw5kL/moZrgN+7JXLP+h6c0jyhvlV8o1ZkSihKF0ONqrFu+O +YCASfyNXCF5gyCqDchFFex0ZCbUXyAQ+C8pOfOPr4a6CB+EZCzvGnIlZjud21YC eNlLIPqbowUimJShErzv2FzUZxGaU11S3EdNmLSwEL/NFvb5Gp50MNvmt/eH4mk1 l3LaHLnpLOdZ56YojheK4GLYzJTKkxpciMHDIkvcA2Dxs91vbbpNjkJExDxdLwyw fodW6NzrxjZottUMYlzOoNIImJYDktB2qsuTX21c909WhVUm147c1OyqHPFDFgw= =yWgY -----END PGP SIGNATURE----- --Jt6n3UW5ECtdQucOrlGAgQD5RLGviES2R--