From: Gonglei <arei.gonglei@huawei.com>
To: Amos Kong <akong@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
"josh.durgin@inktank.com" <josh.durgin@inktank.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"stefanha@redhat.com" <stefanha@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/rbd: fix memory leak
Date: Thu, 4 Dec 2014 15:03:54 +0800 [thread overview]
Message-ID: <5480075A.4090701@huawei.com> (raw)
In-Reply-To: <20141204065144.GC10914@air.redhat.com>
On 2014/12/4 14:51, Amos Kong wrote:
> 'local_err' was defined for collecting error insider qemu_opts_absorb_qdict().
> We should set error to 'errp', then the error can be passed to caller,
> and free the memory in future.
>
> Reviewed-by: Amos Kong <akong@redhat.com>
Thanks :)
Regards,
-Gonglei
next prev parent reply other threads:[~2014-12-04 7:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 6:34 [Qemu-devel] [PATCH] block/rbd: fix memory leak arei.gonglei
2014-12-04 6:51 ` Amos Kong
2014-12-04 7:03 ` Gonglei [this message]
2014-12-11 6:53 ` Gonglei
2014-12-12 13:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5480075A.4090701@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=josh.durgin@inktank.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).