From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Don Koch <dkoch@verizon.com>,
Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it
Date: Thu, 04 Dec 2014 10:00:25 +0100 [thread overview]
Message-ID: <548022A9.3090700@redhat.com> (raw)
In-Reply-To: <1417649314-13704-5-git-send-email-famz@redhat.com>
On 2014-12-04 at 00:28, Fam Zheng wrote:
> Since a too small file cannot be a valid VMDK image, and also since the
> buffer's first 4 bytes will be unconditionally examined by
> vmdk_open_sparse, let's error out the small file case to be clear.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/vmdk.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-12-04 9:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 23:28 [Qemu-devel] [PATCH v4 0/6] vmdk: A few small fixes Fam Zheng
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 1/6] vmdk: Use g_random_int to generate CID Fam Zheng
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 2/6] vmdk: Fix comment to match code of extent lines Fam Zheng
2014-12-04 8:59 ` Max Reitz
2014-12-04 9:14 ` Markus Armbruster
2014-12-04 14:18 ` Don Koch
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 3/6] vmdk: Clean up descriptor file reading Fam Zheng
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 4/6] vmdk: Check descriptor file length when reading it Fam Zheng
2014-12-04 9:00 ` Max Reitz [this message]
2014-12-04 9:14 ` Markus Armbruster
2014-12-04 14:18 ` Don Koch
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 5/6] vmdk: Remove unnecessary initialization Fam Zheng
2014-12-03 23:28 ` [Qemu-devel] [PATCH v4 6/6] vmdk: Set errp on failures in vmdk_open_vmdk4 Fam Zheng
2014-12-04 14:27 ` [Qemu-devel] [PATCH v4 0/6] vmdk: A few small fixes Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548022A9.3090700@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=dkoch@verizon.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).