[Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Jeff Cody]

This removes the unneeded BLOCK_OPT_NOCOW options from vdi
and vpc.

Jeff Cody (2):
  block: remove BLOCK_OPT_NOCOW from vdi_create_opts
  block: remove BLOCK_OPT_NOCOW from vpc_create_opts

 block/vdi.c | 5 -----
 block/vpc.c | 5 -----
 2 files changed, 10 deletions(-)

-- 
1.9.3

[Qemu-devel] [PATCH 1/2] block: remove BLOCK_OPT_NOCOW from vdi_create_opts

[Jeff Cody]

In commit 7074786, the need for NOCOW was removed from the vdi driver,
as we removed the the posix calls.  However, the BLOCK_OPT_NOCOW was not
removed from vdi_create_opts.  This was a mistake - remove the opt from
there as well.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/vdi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/block/vdi.c b/block/vdi.c
index 39070b7..74030c6 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -852,11 +852,6 @@ static QemuOptsList vdi_create_opts = {
             .def_value_str = "off"
         },
 #endif
-        {
-            .name = BLOCK_OPT_NOCOW,
-            .type = QEMU_OPT_BOOL,
-            .help = "Turn off copy-on-write (valid only on btrfs)"
-        },
         /* TODO: An additional option to set UUID values might be useful. */
         { /* end of list */ }
     }
-- 
1.9.3

[Qemu-devel] [PATCH 2/2] block: remove BLOCK_OPT_NOCOW from vpc_create_opts

[Jeff Cody]

In commit fef6070, the need for NOCOW was removed from the vpc driver,
as we removed the the posix calls.  However, the BLOCK_OPT_NOCOW was not
removed from vpc_create_opts.  This was a mistake - remove the opt from
there as well.

Signed-off-by: Jeff Cody <jcody@redhat.com>
---
 block/vpc.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/block/vpc.c b/block/vpc.c
index 38c4f02..46803b1 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -893,11 +893,6 @@ static QemuOptsList vpc_create_opts = {
                 "Type of virtual hard disk format. Supported formats are "
                 "{dynamic (default) | fixed} "
         },
-        {
-            .name = BLOCK_OPT_NOCOW,
-            .type = QEMU_OPT_BOOL,
-            .help = "Turn off copy-on-write (valid only on btrfs)"
-        },
         { /* end of list */ }
     }
 };
-- 
1.9.3

Re: [Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Max Reitz]

On 2014-12-03 at 16:30, Jeff Cody wrote:
> This removes the unneeded BLOCK_OPT_NOCOW options from vdi
> and vpc.
>
> Jeff Cody (2):
>    block: remove BLOCK_OPT_NOCOW from vdi_create_opts
>    block: remove BLOCK_OPT_NOCOW from vpc_create_opts
>
>   block/vdi.c | 5 -----
>   block/vpc.c | 5 -----
>   2 files changed, 10 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

Re: [Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Max Reitz]

On 2014-12-03 at 16:30, Jeff Cody wrote:
> This removes the unneeded BLOCK_OPT_NOCOW options from vdi
> and vpc.
>
> Jeff Cody (2):
>    block: remove BLOCK_OPT_NOCOW from vdi_create_opts
>    block: remove BLOCK_OPT_NOCOW from vpc_create_opts
>
>   block/vdi.c | 5 -----
>   block/vpc.c | 5 -----
>   2 files changed, 10 deletions(-)

Thanks, applied to my block-next tree:

https://github.com/XanClic/qemu/commits/block-next

Re: [Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Stefan Weil]

Am 03.12.2014 um 17:50 schrieb Max Reitz:
> On 2014-12-03 at 16:30, Jeff Cody wrote:
>> This removes the unneeded BLOCK_OPT_NOCOW options from vdi
>> and vpc.
>>
>> Jeff Cody (2):
>>    block: remove BLOCK_OPT_NOCOW from vdi_create_opts
>>    block: remove BLOCK_OPT_NOCOW from vpc_create_opts
>>
>>   block/vdi.c | 5 -----
>>   block/vpc.c | 5 -----
>>   2 files changed, 10 deletions(-)
> 
> Thanks, applied to my block-next tree:
> 
> https://github.com/XanClic/qemu/commits/block-next


You might add this, too, to both patches:

Reviewed-by: Stefan Weil <sw@weilnetz.de>

Re: [Qemu-devel] [PATCH 0/2] Remove BLOCK_OPT_NOCOW from VDI and VPC

[Max Reitz]

On 2014-12-04 at 07:25, Stefan Weil wrote:
> Am 03.12.2014 um 17:50 schrieb Max Reitz:
>> On 2014-12-03 at 16:30, Jeff Cody wrote:
>>> This removes the unneeded BLOCK_OPT_NOCOW options from vdi
>>> and vpc.
>>>
>>> Jeff Cody (2):
>>>     block: remove BLOCK_OPT_NOCOW from vdi_create_opts
>>>     block: remove BLOCK_OPT_NOCOW from vpc_create_opts
>>>
>>>    block/vdi.c | 5 -----
>>>    block/vpc.c | 5 -----
>>>    2 files changed, 10 deletions(-)
>> Thanks, applied to my block-next tree:
>>
>> https://github.com/XanClic/qemu/commits/block-next
>
> You might add this, too, to both patches:
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>

Done, thanks.

Max