From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwY2D-0001jn-Tk for qemu-devel@nongnu.org; Thu, 04 Dec 2014 10:09:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwY29-0000Eg-0E for qemu-devel@nongnu.org; Thu, 04 Dec 2014 10:09:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwY28-0000Ea-Ny for qemu-devel@nongnu.org; Thu, 04 Dec 2014 10:09:32 -0500 Message-ID: <548078D3.90000@redhat.com> Date: Thu, 04 Dec 2014 07:08:03 -0800 From: Eric Blake MIME-Version: 1.0 References: <1416991272-10277-1-git-send-email-bdpayne@acm.org> <1417033667-10364-1-git-send-email-bdpayne@acm.org> <1417033667-10364-2-git-send-email-bdpayne@acm.org> <547CE768.9050405@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="46NqvXVWJlOtSPt0JhORPaqEeNqH3kDD4" Subject: Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Bryan D. Payne" Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --46NqvXVWJlOtSPt0JhORPaqEeNqH3kDD4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/03/2014 03:07 PM, Bryan D. Payne wrote: >> >> In addition to Fam's review, I have a question - does this code proper= ly >> use qemu_open() so that I can use 'add-fd' to pass in a pre-opened >> socket fd into fdset 1, then call pmemaccess with '/dev/fdset/1'? If >> not, can you please fix it to allow this usage? >> >=20 > I'm not familiar with this setup. Could you point me to an example of > where this is done properly somewhere else in the Qemu code base? Once= I > figure this out, I'll be able to post the v3 patch. Off the top of my head, I know the -tpm command line options (related to the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c for that implementation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --46NqvXVWJlOtSPt0JhORPaqEeNqH3kDD4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUgHjdAAoJEKeha0olJ0NqdxsH/3hrh1iMf8ZauGXHUCBsBgup SRfVGncLf1QrVusDKBrrlzmig6twulmIX5Cb+t9Zp1bDO+KxqZNL+gMjZxZyR7+1 0RPY5+EKK/yfKa403f45i5ZZleE4GTeYjeCITm2VNAMPsbXLglR1sBvOUzGvUEn2 zPLqb2yMUAMLxfk0LBX+0Ipq9rzppGFGY78qujQ6X7JXAFoUoKn9ALvegd00/Gkm 1eQ8oQwBUGMousquTlofGIgqllLsWVN/jFe0Vc5+hH6CPcsNheOjoPKqvQmMWl9K o4EXPGXq7tdOnBtm9ZnrXoi+RvE2KbXHsnMrlorRSxWjfpWxQUxylv0UNTJNlXM= =Buf7 -----END PGP SIGNATURE----- --46NqvXVWJlOtSPt0JhORPaqEeNqH3kDD4--