From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xwf7v-0003Rl-IE for qemu-devel@nongnu.org; Thu, 04 Dec 2014 17:44:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xwf7q-0003RC-Ks for qemu-devel@nongnu.org; Thu, 04 Dec 2014 17:43:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xwf7q-0003Qp-6z for qemu-devel@nongnu.org; Thu, 04 Dec 2014 17:43:54 -0500 Message-ID: <5480E3A4.5000704@redhat.com> Date: Thu, 04 Dec 2014 15:43:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1416991272-10277-1-git-send-email-bdpayne@acm.org> <1417033667-10364-1-git-send-email-bdpayne@acm.org> <1417033667-10364-2-git-send-email-bdpayne@acm.org> <547CE768.9050405@redhat.com> <548078D3.90000@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LmvHoKHJHoh4eKV7TnHuThAWFVWaBhvUc" Subject: Re: [Qemu-devel] [PATCH] qmp: extend QMP to provide read/write access to physical memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Bryan D. Payne" Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LmvHoKHJHoh4eKV7TnHuThAWFVWaBhvUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/04/2014 11:40 AM, Bryan D. Payne wrote: >> >> Off the top of my head, I know the -tpm command line options (related = to >> the 'query-tpm' QMP command) do this; look at hw/tpm/tpm_passthrough.c= >> for that implementation. >=20 >=20 > So now I do see what you are talking about. But I don't think it appli= es > to this patch. I'm not using qemu_open in this patch. But my argument is that you SHOULD be using qemu_open, so that someone can have the option of passing in a pre-opened fd rather than having qemu open it. It matters for cases like libvirt where qemu is running under restricted privileges, and it is easier to have libvirt pass in a pre-opened fd than to figure out how to give qemu the privileges it needs to open the file itself. Even if you don't think your feature will be exposed by libvirt any time soon, it's still worth designing things to be flexible from the beginning. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LmvHoKHJHoh4eKV7TnHuThAWFVWaBhvUc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUgOOkAAoJEKeha0olJ0Nq3FAH/RqyctNuQ0E/P/vFY5V88tT+ JLPec93SBuq1ewplDMBwdyhtCHMKlbS+KN8IIs8UGgBdHBosgchsYcQPBBoMvUiV 7+b4u0EtcxQr6C41nXR/QAj9VehjkOcoVuNfAfpnIJ1PD5cU1gi6cXSwWwiMDZt3 xBDKe1eH6caSTTQFWyu+Y6SdipPpSXbAvTs6CcCPZe17hK0GVKiQP6j6X7muIxx2 iFtqIafcItbGw1GZy7xCCKvIR0f84+DWOQyBSiGe9yclnYMy02SiUb7SJ6sOEMnt pJnfwHzNdB1IDSjXp3a0ukZl1VlHMUlyZX5LBg1lTuWQGGV9UxOVyTQw1bt3b0A= =ecyK -----END PGP SIGNATURE----- --LmvHoKHJHoh4eKV7TnHuThAWFVWaBhvUc--