From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, weidong.huang@huawei.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] spice: fix memory leak
Date: Thu, 04 Dec 2014 21:59:16 -0700 [thread overview]
Message-ID: <54813BA4.5040404@redhat.com> (raw)
In-Reply-To: <1417750270-14056-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On 12/04/2014 08:31 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> If errors happen for middle items of channel_list,
> qmp_query_spice_channels() return NULL, and varriable
s/return/returns/
s/varriable/the variable/
> cur_item going out of scope leaks the storage it points to.
> Let's check for errors in advance avoid memory leak.
s/avoid/to avoid a/
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> ui/spice-core.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Maintainer can fix up commit message typos.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-05 4:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 3:31 [Qemu-devel] [PATCH] spice: fix memory leak arei.gonglei
2014-12-05 4:59 ` Eric Blake [this message]
2014-12-05 5:01 ` Gonglei
2014-12-05 7:17 ` Gerd Hoffmann
2014-12-05 7:22 ` Gonglei
2014-12-05 7:39 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2015-02-11 16:44 Gerd Hoffmann
2015-02-11 16:44 ` Paolo Bonzini
2015-02-16 8:30 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54813BA4.5040404@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).