From: Gonglei <arei.gonglei@huawei.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"Huangweidong (C)" <weidong.huang@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] spice: fix memory leak
Date: Fri, 5 Dec 2014 15:22:36 +0800 [thread overview]
Message-ID: <54815D3C.1090608@huawei.com> (raw)
In-Reply-To: <1417763870.11297.4.camel@nilsson.home.kraxel.org>
On 2014/12/5 15:17, Gerd Hoffmann wrote:
> On Fr, 2014-12-05 at 11:31 +0800, arei.gonglei@huawei.com wrote:
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> If errors happen for middle items of channel_list,
>> qmp_query_spice_channels() return NULL, and varriable
>> cur_item going out of scope leaks the storage it points to.
>> Let's check for errors in advance avoid memory leak.
>
> I think we can simply turn that into an assert(). The flag is a
> compatibility thing for older spice-server versions. Meanwhile our
> minimum spice version requirement is new enough that we should never
> ever see this error, and if we do something went very seriously wrong.
>
Fine. Would you like version 2 ?
Regards,
-Gonglei
next prev parent reply other threads:[~2014-12-05 7:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 3:31 [Qemu-devel] [PATCH] spice: fix memory leak arei.gonglei
2014-12-05 4:59 ` Eric Blake
2014-12-05 5:01 ` Gonglei
2014-12-05 7:17 ` Gerd Hoffmann
2014-12-05 7:22 ` Gonglei [this message]
2014-12-05 7:39 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2015-02-11 16:44 Gerd Hoffmann
2015-02-11 16:44 ` Paolo Bonzini
2015-02-16 8:30 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54815D3C.1090608@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).