From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwstS-0007VX-52 for qemu-devel@nongnu.org; Fri, 05 Dec 2014 08:26:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwstM-0006iI-Po for qemu-devel@nongnu.org; Fri, 05 Dec 2014 08:25:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwstM-0006iA-G3 for qemu-devel@nongnu.org; Fri, 05 Dec 2014 08:25:52 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB5DPpn1002582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 5 Dec 2014 08:25:52 -0500 Message-ID: <5481B25F.6070801@redhat.com> Date: Fri, 05 Dec 2014 06:25:51 -0700 From: Eric Blake MIME-Version: 1.0 References: <1417774136-30001-1-git-send-email-mreitz@redhat.com> <1417774136-30001-2-git-send-email-mreitz@redhat.com> <5481AEC7.2010107@redhat.com> <5481B0AF.409@redhat.com> In-Reply-To: <5481B0AF.409@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kUOUmiLjmeDNBF7NP9qCgX3dTdfPAo8bC" Subject: Re: [Qemu-devel] [PATCH v2 1/4] qmp: Introduce blockdev-change-medium List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kUOUmiLjmeDNBF7NP9qCgX3dTdfPAo8bC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/05/2014 06:18 AM, Max Reitz wrote: >> >> Should there be a way to empty a cdrom drive? That is, how do I chang= e >> a drive from visiting a file to being empty? >=20 > Doesn't 'eject' work? Oh, good point. More cross-referencing documentation work, then :) At which point, THIS command can keep a mandatory 'filename', and should probably fail on "" rather than being a synonym to 'eject'. >=20 >> Does passing the empty >> string for mandatory 'filename' do that, or should we be strict and >> state that filename is optional (omit to empty the drive) and that an >> empty string as filename is forbidden? >> >> Please also improve the documentation in qapi-schema.json to have the >> 'change' command mention that it is kept for backwards compatibility, >> but that it is no longer the preferred command and point users to >> 'blockdev-change-medium'. >=20 > And to 'change-vnc-password'. Will do. >=20 > Max >=20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kUOUmiLjmeDNBF7NP9qCgX3dTdfPAo8bC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUgbJfAAoJEKeha0olJ0NqB+0H/3/36ubVjS/8HK5NzTIwksYR r2ek1Io8IcmbIQVLtvJPwf3CZ57aM3k3w2dw62Jn2f/cllnwLjeet5gUaLkZpmki b3WPZ5U+AlzJKskinqa0+QYckUSDgEVJH/xllaHefHJVxaCVXR2jFF47nQtygYNc 1giP9idoXYhUbPioSr46LmV0q4mrZLZi3tsf4PJMbNqjHkHttXgzl2VJAIaiZVsX w/POPjBtmBpCBghUurExePz5dragdPmgpfNZhOEpJFb/7vmXTQt+xs/4tAuapNsN /ZgzAIU51EN9HiX4jwoXi50HuI8xKAUyC0AN1yCceb6icYo5fnuj+kfHoNQxG9Y= =ALnj -----END PGP SIGNATURE----- --kUOUmiLjmeDNBF7NP9qCgX3dTdfPAo8bC--