From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Michael Müller" <mimu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] qemu-io: Add sigraise command
Date: Fri, 05 Dec 2014 07:12:26 -0700 [thread overview]
Message-ID: <5481BD4A.8000503@redhat.com> (raw)
In-Reply-To: <87vblqtcwz.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On 12/05/2014 06:59 AM, Markus Armbruster wrote:
>>>>>> Thus, -c abort is not always useful to simulate a qemu-io crash;
>>>>>> therefore, this patch adds a new sigraise command which allows to raise
>>>>>> any Unix signal.
> I'd write "allows to raise a signal", since I trust folks that have a
> need for this feature to know what signal means in this context. But if
> you'd rather write "raise a Unix signal", then that's clearly covered by
> your artistic license.
Actually, I'd write "allows raising a signal"; since "allows to" is an
awkward construction not usually heard in native English.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-05 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 14:48 [Qemu-devel] [PATCH v2 0/3] iotests: Fix test 039 Max Reitz
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 1/3] qemu-io: Add sigraise command Max Reitz
2014-12-05 7:03 ` Fam Zheng
2014-12-05 9:52 ` Markus Armbruster
2014-12-05 10:07 ` Max Reitz
2014-12-05 12:23 ` Markus Armbruster
2014-12-05 13:04 ` Kevin Wolf
2014-12-05 13:05 ` Max Reitz
2014-12-05 13:59 ` Markus Armbruster
2014-12-05 14:12 ` Eric Blake [this message]
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 2/3] iotests: Filter for "Killed" in qemu-io output Max Reitz
2014-12-05 7:04 ` Fam Zheng
2014-12-04 14:49 ` [Qemu-devel] [PATCH v2 3/3] iotests: Fix test 039 Max Reitz
2014-12-05 7:08 ` Fam Zheng
2014-12-05 9:03 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481BD4A.8000503@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).