From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwwrF-00046O-10 for qemu-devel@nongnu.org; Fri, 05 Dec 2014 12:40:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xwwr8-0002o7-OZ for qemu-devel@nongnu.org; Fri, 05 Dec 2014 12:39:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xwwr8-0002nt-Gi for qemu-devel@nongnu.org; Fri, 05 Dec 2014 12:39:50 -0500 Message-ID: <5481EDD1.1030100@redhat.com> Date: Fri, 05 Dec 2014 18:39:29 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <5477B0FD.9040806@redhat.com> <1417130367-17777-1-git-send-email-lersek@redhat.com> <1417130367-17777-2-git-send-email-lersek@redhat.com> In-Reply-To: <1417130367-17777-2-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [edk2] [edk2 PATCH 01/12] ArmVirtualizationPkg: VirtFdtDxe: forward FwCfg addresses from DTB to PCDs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olivier Martin Cc: peter.maydell@linaro.org, drjones@redhat.com, edk2-devel@lists.sourceforge.net, qemu-devel@nongnu.org, ard.biesheuvel@linaro.org On 11/28/14 00:19, Laszlo Ersek wrote: > Qemu's firmware configuration interface consists of two MMIO registers, a > 16-bit selector and an 8-bit data register. Parse their addresses and > verify their sizes from the DTB, and expose them to the rest of DXE by > storing them in dynamic PCDs. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf | 2 ++ > ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c | 26 ++++++++++++++++++++++++++ > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationPkg.dec | 3 +++ > ArmPlatformPkg/ArmVirtualizationPkg/ArmVirtualizationQemu.dsc | 3 +++ > 4 files changed, 34 insertions(+) > > diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf b/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf > index 1c9dd20..daafe6c 100644 > --- a/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf > +++ b/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.inf > @@ -47,6 +47,8 @@ > [Pcd] > gArmVirtualizationTokenSpaceGuid.PcdDeviceTreeBaseAddress > gArmVirtualizationTokenSpaceGuid.PcdArmPsciMethod > + gArmVirtualizationTokenSpaceGuid.PcdFwCfgSelectorAddress > + gArmVirtualizationTokenSpaceGuid.PcdFwCfgDataAddress > gArmTokenSpaceGuid.PcdGicDistributorBase > gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase > gArmTokenSpaceGuid.PcdArmArchTimerSecIntrNum > diff --git a/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c b/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c > index d002e66..f1b5283 100644 > --- a/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c > +++ b/ArmPlatformPkg/ArmVirtualizationPkg/VirtFdtDxe/VirtFdtDxe.c > @@ -44,6 +44,7 @@ typedef enum { > PropertyTypeUart, > PropertyTypeTimer, > PropertyTypePsci, > + PropertyTypeFwCfg, > } PROPERTY_TYPE; > > typedef struct { > @@ -59,6 +60,7 @@ STATIC CONST PROPERTY CompatibleProperties[] = { > { PropertyTypeTimer, "arm,armv7-timer" }, > { PropertyTypeTimer, "arm,armv8-timer" }, > { PropertyTypePsci, "arm,psci-0.2" }, > + { PropertyTypeFwCfg, "fw-cfg,mmio" }, The part of the DTB that exposes this device was slightly changed. Since there were no review comments thus far, I'll post a v2 of this edk2 series. Thanks Laszlo