From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwxSS-0005zu-Vn for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:18:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwxSJ-0001qH-Ux for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:18:24 -0500 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:35200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwxSJ-0001pT-OG for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:18:15 -0500 Received: by mail-wi0-f179.google.com with SMTP id ex7so2256244wid.12 for ; Fri, 05 Dec 2014 10:18:15 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5481F6E3.9000607@redhat.com> Date: Fri, 05 Dec 2014 19:18:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417801466-23485-1-git-send-email-pbonzini@redhat.com> <1417801466-23485-2-git-send-email-pbonzini@redhat.com> <20141205181430.GD5002@thinpad.lan.raisama.net> In-Reply-To: <20141205181430.GD5002@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] pc: add 2.3 machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 05/12/2014 19:14, Eduardo Habkost wrote: >> > #define PC_I440FX_2_2_MACHINE_OPTIONS \ >> > PC_I440FX_MACHINE_OPTIONS, \ > I was going to suggest making PC_I440FX_2_2_MACHINE_OPTIONS reuse > PC_I440FX_2_3_MACHINE_OPTIONS, but I think we have enough macro reuse > mess here, and this is safer and simpler? Yeah, this is following for default_display what the file was already doing for default_machine_opts. Paolo