From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] target-i386: add VME to all CPUs
Date: Fri, 05 Dec 2014 19:36:16 +0100 [thread overview]
Message-ID: <5481FB20.9040804@redhat.com> (raw)
In-Reply-To: <20141205183251.GE5002@thinpad.lan.raisama.net>
On 05/12/2014 19:32, Eduardo Habkost wrote:
>> > vm86 mode extensions date back to the 486. All models should have
>> > them.
>> >
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> TCG doesn't support VME (that's probably why we didn't have it set on
> most CPU models), and I would like to eventually make check/enforce mode
> work on TCG as well.
>
> I was going to suggest adding it to kvm_default_features instead, but as
> we have existing models that have CPUID_VME already, let's be consistent
> and add it to all of them (and deal with TCG check/enforce mode later,
> if necessary).
Yes, my thoughts as well. The weird thing is that we have it on the
really old models that TCG ought to emulate almost completely, but not
on the newer ones...
We can add tcg_default_unset_features too.
Paolo
next prev parent reply other threads:[~2014-12-05 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 17:44 [Qemu-devel] [PATCH 0/3] x86 CPU model fixes Paolo Bonzini
2014-12-05 17:44 ` [Qemu-devel] [PATCH 1/4] pc: add 2.3 machine types Paolo Bonzini
2014-12-05 18:14 ` Eduardo Habkost
2014-12-05 18:18 ` Paolo Bonzini
2014-12-05 17:44 ` [Qemu-devel] [PATCH 2/4] target-i386: add VME to all CPUs Paolo Bonzini
2014-12-05 18:32 ` Eduardo Habkost
2014-12-05 18:36 ` Paolo Bonzini [this message]
2014-12-05 17:44 ` [Qemu-devel] [PATCH 3/4] target-i386: add f16c and rdrand to Haswell and Broadwell Paolo Bonzini
2014-12-05 18:35 ` Eduardo Habkost
2014-12-05 17:44 ` [Qemu-devel] [PATCH 4/4] target-i386: add Ivy Bridge CPU model Paolo Bonzini
2014-12-05 18:36 ` Eduardo Habkost
2014-12-05 18:39 ` Paolo Bonzini
2014-12-05 18:58 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5481FB20.9040804@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).