From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xwxjv-000317-KR for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:36:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xwxjp-0002tq-GM for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:36:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xwxjp-0002tN-9F for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:36:21 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB5IaKUJ016251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 5 Dec 2014 13:36:20 -0500 Message-ID: <5481FB20.9040804@redhat.com> Date: Fri, 05 Dec 2014 19:36:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417801466-23485-1-git-send-email-pbonzini@redhat.com> <1417801466-23485-3-git-send-email-pbonzini@redhat.com> <20141205183251.GE5002@thinpad.lan.raisama.net> In-Reply-To: <20141205183251.GE5002@thinpad.lan.raisama.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] target-i386: add VME to all CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 05/12/2014 19:32, Eduardo Habkost wrote: >> > vm86 mode extensions date back to the 486. All models should have >> > them. >> > >> > Signed-off-by: Paolo Bonzini > TCG doesn't support VME (that's probably why we didn't have it set on > most CPU models), and I would like to eventually make check/enforce mode > work on TCG as well. > > I was going to suggest adding it to kvm_default_features instead, but as > we have existing models that have CPUID_VME already, let's be consistent > and add it to all of them (and deal with TCG check/enforce mode later, > if necessary). Yes, my thoughts as well. The weird thing is that we have it on the really old models that TCG ought to emulate almost completely, but not on the newer ones... We can add tcg_default_unset_features too. Paolo