qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] target-i386: add Ivy Bridge CPU model
Date: Fri, 05 Dec 2014 19:39:49 +0100	[thread overview]
Message-ID: <5481FBF5.3080005@redhat.com> (raw)
In-Reply-To: <20141205183601.GG5002@thinpad.lan.raisama.net>



On 05/12/2014 19:36, Eduardo Habkost wrote:
> On Fri, Dec 05, 2014 at 06:44:26PM +0100, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  target-i386/cpu.c | 34 +++++++++++++++++++++++++++++++++-
>>  1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index b2bb9a4..7767564 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -1039,7 +1039,39 @@ static X86CPUDefinition builtin_x86_defs[] = {
>>          .features[FEAT_XSAVE] =
>>              CPUID_XSAVE_XSAVEOPT,
>>          .xlevel = 0x8000000A,
>> -        .model_id = "Intel Xeon E312xx (Sandy Bridge)",
>> +        .model_id = "Intel Xeon E3-12xx (Sandy Bridge)",
> 
> ABI change. Can we do that in a separate patch?

We can just leave the typo in, I didn't know this was an ABI change.

Paolo

  reply	other threads:[~2014-12-05 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05 17:44 [Qemu-devel] [PATCH 0/3] x86 CPU model fixes Paolo Bonzini
2014-12-05 17:44 ` [Qemu-devel] [PATCH 1/4] pc: add 2.3 machine types Paolo Bonzini
2014-12-05 18:14   ` Eduardo Habkost
2014-12-05 18:18     ` Paolo Bonzini
2014-12-05 17:44 ` [Qemu-devel] [PATCH 2/4] target-i386: add VME to all CPUs Paolo Bonzini
2014-12-05 18:32   ` Eduardo Habkost
2014-12-05 18:36     ` Paolo Bonzini
2014-12-05 17:44 ` [Qemu-devel] [PATCH 3/4] target-i386: add f16c and rdrand to Haswell and Broadwell Paolo Bonzini
2014-12-05 18:35   ` Eduardo Habkost
2014-12-05 17:44 ` [Qemu-devel] [PATCH 4/4] target-i386: add Ivy Bridge CPU model Paolo Bonzini
2014-12-05 18:36   ` Eduardo Habkost
2014-12-05 18:39     ` Paolo Bonzini [this message]
2014-12-05 18:58   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5481FBF5.3080005@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).