From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwxnM-0008QF-QR for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:40:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwxnG-0003tE-M5 for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:40:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwxnG-0003tA-EF for qemu-devel@nongnu.org; Fri, 05 Dec 2014 13:39:54 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB5IdrAl018222 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 5 Dec 2014 13:39:53 -0500 Message-ID: <5481FBF5.3080005@redhat.com> Date: Fri, 05 Dec 2014 19:39:49 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417801466-23485-1-git-send-email-pbonzini@redhat.com> <1417801466-23485-5-git-send-email-pbonzini@redhat.com> <20141205183601.GG5002@thinpad.lan.raisama.net> In-Reply-To: <20141205183601.GG5002@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] target-i386: add Ivy Bridge CPU model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org On 05/12/2014 19:36, Eduardo Habkost wrote: > On Fri, Dec 05, 2014 at 06:44:26PM +0100, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> target-i386/cpu.c | 34 +++++++++++++++++++++++++++++++++- >> 1 file changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index b2bb9a4..7767564 100644 >> --- a/target-i386/cpu.c >> +++ b/target-i386/cpu.c >> @@ -1039,7 +1039,39 @@ static X86CPUDefinition builtin_x86_defs[] = { >> .features[FEAT_XSAVE] = >> CPUID_XSAVE_XSAVEOPT, >> .xlevel = 0x8000000A, >> - .model_id = "Intel Xeon E312xx (Sandy Bridge)", >> + .model_id = "Intel Xeon E3-12xx (Sandy Bridge)", > > ABI change. Can we do that in a separate patch? We can just leave the typo in, I didn't know this was an ABI change. Paolo