From: Christian Schoenebeck <schoenebeck@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-block@nongnu.org, richard.henderson@linaro.org,
eblake@redhat.com
Subject: Re: [PULL 0/7] nbd: handle AioContext change correctly
Date: Sat, 12 Feb 2022 14:13:43 +0100 [thread overview]
Message-ID: <54823717.cdBbltbcZa@silver> (raw)
In-Reply-To: <101e60ea-b752-887b-8b8e-f73561266357@virtuozzo.com>
On Freitag, 11. Februar 2022 14:04:44 CET Vladimir Sementsov-Ogievskiy wrote:
> 11.02.2022 15:52, Peter Maydell wrote:
> > On Wed, 9 Feb 2022 at 14:03, Vladimir Sementsov-Ogievskiy
> >
> > <vsementsov@virtuozzo.com> wrote:
> >> The following changes since commit
0a301624c2f4ced3331ffd5bce85b4274fe132af:
> >> Merge remote-tracking branch
> >> 'remotes/pmaydell/tags/pull-target-arm-20220208' into staging
> >> (2022-02-08 11:40:08 +0000)>>
> >> are available in the Git repository at:
> >> https://src.openvz.org/scm/~vsementsov/qemu.git
> >> tags/pull-nbd-2022-02-09
> >>
> >> for you to fetch changes up to 1bd4523c2ded28b7805b971b9d3d746beabd0a94:
> >> iotests/281: Let NBD connection yield in iothread (2022-02-09 14:15:29
> >> +0100)>>
> >> ----------------------------------------------------------------
> >> nbd: handle AioContext change correctly
> >
> > Hi; this pullreq is OK content-wise, but the commits are missing
> > your Signed-off-by: line as the submaintainer/submitter of the
> > pull request. Could you add them and resend, please?
>
> Oops, sorry. I thought I'm already an experienced maintainer and don't need
> to re-read "Submitting a Pull Request" instruction every time. I was
> wrong:)
Assuming you are using pwclient to pull patchtes, just add
signoff=on
to your .pwclientrc config file to automatically add your signoff tag to
pulled patches. Additionally I would recommend adding:
msgid=on
which will add the email message id of each patch, so that people can review
the discussions on qemu-devel later on if needed. On Linux kernel side it's
now more common to add a Link: tag, which is a bit more convenient as people
can just click on it to get to the discussion. Not sure if there is config
option for pwclient for that as well.
Best regards,
Christian Schoenebeck
prev parent reply other threads:[~2022-02-12 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 14:02 [PULL 0/7] nbd: handle AioContext change correctly Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 1/7] block/nbd: Delete reconnect delay timer when done Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 2/7] block/nbd: Delete open " Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 3/7] block/nbd: Assert there are no timers when closed Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 4/7] iotests.py: Add QemuStorageDaemon class Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 5/7] iotests/281: Test lingering timers Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 6/7] block/nbd: Move s->ioc on AioContext change Vladimir Sementsov-Ogievskiy
2022-02-09 14:02 ` [PULL 7/7] iotests/281: Let NBD connection yield in iothread Vladimir Sementsov-Ogievskiy
2022-02-11 12:52 ` [PULL 0/7] nbd: handle AioContext change correctly Peter Maydell
2022-02-11 13:04 ` Vladimir Sementsov-Ogievskiy
2022-02-12 13:13 ` Christian Schoenebeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54823717.cdBbltbcZa@silver \
--to=schoenebeck@crudebyte.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).