From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Xxwjb-00010Q-FH
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 06:44:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XxwjW-0002vU-LO
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 06:44:11 -0500
Received: from szxga02-in.huawei.com ([119.145.14.65]:46231)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1XxwjV-0002s0-UZ
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 06:44:06 -0500
Message-ID: <54858EE5.7030500@huawei.com>
Date: Mon, 8 Dec 2014 19:43:33 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1416474426-12176-1-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1416474426-12176-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset="GB2312"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vnc-enc-tight: fix Arguments in wrong order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 2014/11/20 17:07, Gonglei (Arei) wrote:

> From: Gonglei <arei.gonglei@huawei.com>
> 
> Arguments in wrong order (SWAPPED_ARGUMENTS)
> The positions of arguments in the call to
> tight_fill_palette do not match the ordering of the parameters:
>  &fg is passed to bg
>  &bg is passed to fg
> 
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
>  ui/vnc-enc-tight.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
> index 3d1b5cd..9a9ddf2 100644
> --- a/ui/vnc-enc-tight.c
> +++ b/ui/vnc-enc-tight.c
> @@ -1489,7 +1489,7 @@ static int send_sub_rect(VncState *vs, int x, int y, int w, int h)
>      }
>  #endif
>  
> -    colors = tight_fill_palette(vs, x, y, w * h, &fg, &bg, &palette);
> +    colors = tight_fill_palette(vs, x, y, w * h, &bg, &fg, &palette);
>  
>  #ifdef CONFIG_VNC_JPEG
>      if (allow_jpeg && vs->tight.quality != (uint8_t)-1) {

Ping...

Regards,
-Gonglei