From: Gonglei <arei.gonglei@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mst@redhat.com" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define
Date: Tue, 9 Dec 2014 09:49:32 +0800 [thread overview]
Message-ID: <5486552C.9020503@huawei.com> (raw)
In-Reply-To: <87wq626tq8.fsf@blackfin.pond.sub.org>
On 2014/12/8 23:34, Markus Armbruster wrote:
> <arei.gonglei@huawei.com> writes:
>
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> commit 1773d9ee (virtio-net: cleanup: init and exit function)
>> had removed realization of virtio_net_init(), but didn't remove
>> the define of head file. Let's remove it.
>>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>
> I get what you mean by "realization", but the technical term is
> definition, and the thing you remove is a declaration.
>
Thanks for your point. :)
> Suggest
>
> virtio: remove useless declaration of virtio_net_init()
>
> Commit 1773d9ee (virtio-net: cleanup: init and exit function)
> removed the definition of virtio_net_init(), but didn't remove its
> declaration in the header. Clean that up.
OK, will do.
Regards,
-Gonglei
prev parent reply other threads:[~2014-12-09 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 11:48 [Qemu-devel] [PATCH] virtio: remove useless virtio_net_init define arei.gonglei
2014-12-08 15:34 ` Markus Armbruster
2014-12-09 1:49 ` Gonglei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5486552C.9020503@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).