From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42189)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XyI4Y-0005BL-U9
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:31:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XyI4P-0003YH-8e
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:31:14 -0500
Received: from mail-wg0-f41.google.com ([74.125.82.41]:47568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eric.auger@linaro.org>) id 1XyI4P-0003Y3-3B
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:31:05 -0500
Received: by mail-wg0-f41.google.com with SMTP id y19so424264wgg.0
	for <qemu-devel@nongnu.org>; Tue, 09 Dec 2014 02:31:04 -0800 (PST)
Message-ID: <5486CF14.30501@linaro.org>
Date: Tue, 09 Dec 2014 11:29:40 +0100
From: Eric Auger <eric.auger@linaro.org>
MIME-Version: 1.0
References: <1417371570-11789-1-git-send-email-eric.auger@linaro.org>
	<1417371570-11789-2-git-send-email-eric.auger@linaro.org>
	<CAFEAcA-N1iW2ugyawBAynnXELvnG=VezxObKuMQ82vD=EPauCA@mail.gmail.com>
	<CAFEAcA-kyso9LZd0Dm3g-2PtFg1U2c41gz8ELpGDWntM0nf64w@mail.gmail.com>
In-Reply-To: <CAFEAcA-kyso9LZd0Dm3g-2PtFg1U2c41gz8ELpGDWntM0nf64w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 1/6] hw/arm/boot: load_dtb becomes non
	static arm_load_dtb
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Joel Schopp <joel.schopp@amd.com>, Kim Phillips <kim.phillips@freescale.com>, eric.auger@st.com, Antonios Motakis <a.motakis@virtualopensystems.com>, Alvise Rigo <a.rigo@virtualopensystems.com>, manish.jaggi@caviumnetworks.com, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Will Deacon <will.deacon@arm.com>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Bharat Bhushan <Bharat.Bhushan@freescale.com>, Alex Williamson <alex.williamson@redhat.com>, Patch Tracking <patches@linaro.org>, Shannon Zhao <zhaoshenglong@huawei.com>, Stuart Yoder <stuart.yoder@freescale.com>, Paolo Bonzini <pbonzini@redhat.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On 12/05/2014 07:16 PM, Peter Maydell wrote:
> On 5 December 2014 at 16:38, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 30 November 2014 at 18:19, Eric Auger <eric.auger@linaro.org> wrote:
>>> load_dtb is renamed into arm_load_dtb and becomes non static.
>>> it will be used by machvirt for dynamic instantiation of
>>> platform devices
>>
>> 'virt' shouldn't be a special case -- we should always
>> handle setting up the DTB in guest memory in the same
>> way, whether there happens to be a vfio platform device
>> available or not.
> 
> ...this probably means that a bunch of the work currently
> done in arm_load_kernel() should be deferred to a 'machine
> init complete' hook (perhaps all of it?).

Hi Peter,

OK

I moved the arm_load_kernel code into a machine init done notify and
arm_load_kernel now only registers the notifier.
For machine files willing to support platform bus, the arm_load_kernel
must happen before the registration of the notifier that adds platform
bus nodes and after CPU init (notifiers are executed in registration
reverse order).

Best Regards

Eric
> 
> -- PMM
>