From: Peter Lieven <pl@kamp.de>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net,
ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH V2 4/4] virtio-blk: introduce multiread
Date: Tue, 09 Dec 2014 16:44:59 +0100 [thread overview]
Message-ID: <548718FB.6020603@kamp.de> (raw)
In-Reply-To: <5481C9CB.70805@redhat.com>
On 05.12.2014 16:05, Eric Blake wrote:
> On 12/05/2014 04:50 AM, Peter Lieven wrote:
>> this patch finally introduce multiread support to virtio-blk while
> s/introduce/introduces/
> s/virtio-blk while/virtio-blk. While/
>
>> multiwrite support was there for a long time read support was missing.
> s/time/time,/
>
>> To achieve this the patch does serveral things which might need futher
> s/serveral/several/
> s/futher/further/
>
>> explaination:
> s/explaination/explanation/
>
>> - the whole merge and multireq logic is moved from block.c into
>> virtio-blk. This is move is a preparation for directly creating a
>> coroutine out of virtio-blk.
> Can this move be done as a separate prerequisite patch? Mixing code
> motion and new features in the same patch is harder to review.
The issue is that the code is not movable. I could artifically use
the new code in a new patch only for write requests and add
another patch to add read merging. But I doubt that it would make
it easier to review but even harder.
Peter
prev parent reply other threads:[~2014-12-09 15:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 11:50 [Qemu-devel] [RFC PATCH V2 0/4] virtio-blk: add multiread support Peter Lieven
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 1/4] block: add accounting for merged requests Peter Lieven
2014-12-05 14:58 ` Eric Blake
2014-12-09 15:43 ` Peter Lieven
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 2/4] hw/virtio-blk: add a constant for max number of " Peter Lieven
2014-12-05 14:59 ` Eric Blake
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 3/4] block-backend: expose bs->bl.max_transfer_length Peter Lieven
2014-12-05 11:50 ` [Qemu-devel] [RFC PATCH V2 4/4] virtio-blk: introduce multiread Peter Lieven
2014-12-05 15:05 ` Eric Blake
2014-12-09 15:44 ` Peter Lieven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548718FB.6020603@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).