From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42892)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XyMyP-00071Q-Ki
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:45:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1XyMyG-0006Yh-K9
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:45:13 -0500
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:44224 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1XyMyG-0006Vh-7y
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 10:45:04 -0500
Message-ID: <548718FB.6020603@kamp.de>
Date: Tue, 09 Dec 2014 16:44:59 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1417780229-6930-1-git-send-email-pl@kamp.de>
	<1417780229-6930-5-git-send-email-pl@kamp.de>
	<5481C9CB.70805@redhat.com>
In-Reply-To: <5481C9CB.70805@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V2 4/4] virtio-blk: introduce multiread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com

On 05.12.2014 16:05, Eric Blake wrote:
> On 12/05/2014 04:50 AM, Peter Lieven wrote:
>> this patch finally introduce multiread support to virtio-blk while
> s/introduce/introduces/
> s/virtio-blk while/virtio-blk. While/
>
>> multiwrite support was there for a long time read support was missing.
> s/time/time,/
>
>> To achieve this the patch does serveral things which might need futher
> s/serveral/several/
> s/futher/further/
>
>> explaination:
> s/explaination/explanation/
>
>>   - the whole merge and multireq logic is moved from block.c into
>>     virtio-blk. This is move is a preparation for directly creating a
>>     coroutine out of virtio-blk.
> Can this move be done as a separate prerequisite patch? Mixing code
> motion and new features in the same patch is harder to review.

The issue is that the code is not movable. I could artifically use
the new code in a new patch only for write requests and add
another patch to add read merging. But I doubt that it would make
it easier to review but even harder.

Peter