From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyOqo-0003oz-RN for qemu-devel@nongnu.org; Tue, 09 Dec 2014 12:45:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyOqi-0006JW-I3 for qemu-devel@nongnu.org; Tue, 09 Dec 2014 12:45:30 -0500 Message-ID: <5487351C.9020706@redhat.com> Date: Tue, 09 Dec 2014 18:45:00 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417796112-15141-1-git-send-email-ming.lei@canonical.com> <5481DE62.4000206@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] block: fix big write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei Cc: Kevin Wolf , qemu-stable@nongnu.org, qemu-devel , Stefan Hajnoczi , Ming Lei On 08/12/2014 08:19, Ming Lei wrote: >> > >> > Alternatively, I'd accept a SCSI patch setting max_ws_blocks and friends >> > to 2GB - 1 block. > It should be better to not introduce the limit and split the writes > into size of 2GB - 1 block since there is only the limit for write zero. Why? That's exactly what the max_ws_blocks is for, and there's code in the guest already to do the split. We're talking about 2GB, not 1MB. Paolo