From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XydxT-00065Q-8Y
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 04:53:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XydxK-0007jp-8e
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 04:53:23 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <548817F4.4070402@redhat.com>
Date: Wed, 10 Dec 2014 10:52:52 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1417976445-18860-1-git-send-email-antonynpavlov@gmail.com>
	<54880E36.9080701@msgid.tls.msk.ru>
In-Reply-To: <54880E36.9080701@msgid.tls.msk.ru>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi02.c: associate
 "cfi.pflash02" to "Storage devices" category
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>, Antony Pavlov <antonynpavlov@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>



On 10/12/2014 10:11, Michael Tokarev wrote:
> 07.12.2014 21:20, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>>  hw/block/pflash_cfi02.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
>> index 8513a17..389b4aa 100644
>> --- a/hw/block/pflash_cfi02.c
>> +++ b/hw/block/pflash_cfi02.c
>> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
>>  
>>      dc->realize = pflash_cfi02_realize;
>>      dc->props = pflash_cfi02_properties;
>> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>>  }
>>  
>>  static const TypeInfo pflash_cfi02_info = {
> 
> Hm.  While the patch itself is trivial, and it _seems_ it
> fixes a bug, I'm not sure of possible effects of this.
> 
> What prob it has now, does this device work?  If yes,
> why it needs fixing?  Do we care about compatibility
> with previous versions, about migration?

This affects nothing but help messages.

Paolo