* [Qemu-devel] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
@ 2014-12-07 18:20 Antony Pavlov
2014-12-10 9:11 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-12-10 11:29 ` Michael Tokarev
0 siblings, 2 replies; 4+ messages in thread
From: Antony Pavlov @ 2014-12-07 18:20 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Antony Pavlov
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
hw/block/pflash_cfi02.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
index 8513a17..389b4aa 100644
--- a/hw/block/pflash_cfi02.c
+++ b/hw/block/pflash_cfi02.c
@@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
dc->realize = pflash_cfi02_realize;
dc->props = pflash_cfi02_properties;
+ set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
}
static const TypeInfo pflash_cfi02_info = {
--
2.1.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
2014-12-07 18:20 [Qemu-devel] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category Antony Pavlov
@ 2014-12-10 9:11 ` Michael Tokarev
2014-12-10 9:52 ` Paolo Bonzini
2014-12-10 11:29 ` Michael Tokarev
1 sibling, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2014-12-10 9:11 UTC (permalink / raw)
To: Antony Pavlov, qemu-devel; +Cc: qemu-trivial, Kevin Wolf, Stefan Hajnoczi
07.12.2014 21:20, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> hw/block/pflash_cfi02.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
> index 8513a17..389b4aa 100644
> --- a/hw/block/pflash_cfi02.c
> +++ b/hw/block/pflash_cfi02.c
> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
>
> dc->realize = pflash_cfi02_realize;
> dc->props = pflash_cfi02_properties;
> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
> }
>
> static const TypeInfo pflash_cfi02_info = {
Hm. While the patch itself is trivial, and it _seems_ it
fixes a bug, I'm not sure of possible effects of this.
What prob it has now, does this device work? If yes,
why it needs fixing? Do we care about compatibility
with previous versions, about migration?
Cc'ing block device people...
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
2014-12-10 9:11 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-12-10 9:52 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-12-10 9:52 UTC (permalink / raw)
To: Michael Tokarev, Antony Pavlov, qemu-devel
Cc: qemu-trivial, Kevin Wolf, Stefan Hajnoczi
On 10/12/2014 10:11, Michael Tokarev wrote:
> 07.12.2014 21:20, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>> ---
>> hw/block/pflash_cfi02.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/block/pflash_cfi02.c b/hw/block/pflash_cfi02.c
>> index 8513a17..389b4aa 100644
>> --- a/hw/block/pflash_cfi02.c
>> +++ b/hw/block/pflash_cfi02.c
>> @@ -744,6 +744,7 @@ static void pflash_cfi02_class_init(ObjectClass *klass, void *data)
>>
>> dc->realize = pflash_cfi02_realize;
>> dc->props = pflash_cfi02_properties;
>> + set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>> }
>>
>> static const TypeInfo pflash_cfi02_info = {
>
> Hm. While the patch itself is trivial, and it _seems_ it
> fixes a bug, I'm not sure of possible effects of this.
>
> What prob it has now, does this device work? If yes,
> why it needs fixing? Do we care about compatibility
> with previous versions, about migration?
This affects nothing but help messages.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category
2014-12-07 18:20 [Qemu-devel] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category Antony Pavlov
2014-12-10 9:11 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-12-10 11:29 ` Michael Tokarev
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2014-12-10 11:29 UTC (permalink / raw)
To: Antony Pavlov, qemu-devel; +Cc: qemu-trivial
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-10 11:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 18:20 [Qemu-devel] [PATCH] pflash_cfi02.c: associate "cfi.pflash02" to "Storage devices" category Antony Pavlov
2014-12-10 9:11 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-12-10 9:52 ` Paolo Bonzini
2014-12-10 11:29 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).