From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyfbO-0006A3-38 for qemu-devel@nongnu.org; Wed, 10 Dec 2014 06:38:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyfbH-0000kh-UN for qemu-devel@nongnu.org; Wed, 10 Dec 2014 06:38:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyfbH-0000jz-NG for qemu-devel@nongnu.org; Wed, 10 Dec 2014 06:38:35 -0500 Message-ID: <548830A9.3090103@redhat.com> Date: Wed, 10 Dec 2014 12:38:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417795568-3201-1-git-send-email-kwolf@redhat.com> <1417795568-3201-7-git-send-email-kwolf@redhat.com> <5481F64A.3070203@redhat.com> <20141208093455.GA3792@noname.str.redhat.com> In-Reply-To: <20141208093455.GA3792@noname.str.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 6/6] linux-aio: Queue requests instead of returning -EAGAIN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: ming.lei@canonical.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com On 08/12/2014 10:34, Kevin Wolf wrote: > Also note that this specific patch is doing an additional step that > isn't part of Ming's series: Ming's series simply lets requests fail if > the queue is full. That's true. Perhaps I was just exposed a lot to his code. > I honestly expected that people > would debate whether it does the right thing I'm pretty sure that it does the right thing (minus the comment about plug/unplug). Paolo