From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylKk-0000BS-2U for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XylKf-0002OX-1q for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylKe-0002OP-Q1 for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:48 -0500 Message-ID: <54887A35.3070801@redhat.com> Date: Wed, 10 Dec 2014 09:52:05 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1418204253-5869-10-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4DGj1ikvNrt8SD4KWgvJ4RqnPt4bn2VAa" Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Markus Armbruster , Anthony Liguori , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4DGj1ikvNrt8SD4KWgvJ4RqnPt4bn2VAa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/10/2014 02:37 AM, Gerd Hoffmann wrote: > Add new query vnc qmp command, for the lack of better ideas just name i= t > "query-vnc2". Changes over query-vnc: >=20 > * It returns a list of vnc servers, so multiple vnc server instances > are covered. > * Each vnc server returns a list of server sockets. Followup patch > will use that to also report websockets. In case we add support for= > multiple server sockets server sockets (to better support ipv4+ipv6 > dualstack) we can add them to the list too. >=20 > Signed-off-by: Gerd Hoffmann > --- > +# @VncInfo2: > +# > +# Information about a vnc server > +# > +# @id: vnc server name. > +# > +# @server: A list of @VncBasincInfo describing all listening sockets. > +# The list can be empty (in case the vnc server is disabled).= > +# It also may have multiple entries: normal + websocket, > +# possibly also ipv4 + ipv6 in the future. > +# > +# @clients: A list of @VncClientInfo of all currently connected client= s. > +# The list can be empty, for obvious reasons. Seems okay. > +# > +# @auth: The current authentication type used by the server > +# 'none' if no authentication is being used > +# 'vnc' if VNC authentication is being used > +# 'vencrypt+plain' if VEncrypt is used with plain text authenti= cation > +# 'vencrypt+tls+none' if VEncrypt is used with TLS and no authe= ntication > +# 'vencrypt+tls+vnc' if VEncrypt is used with TLS and VNC authe= ntication > +# 'vencrypt+tls+plain' if VEncrypt is used with TLS and plain t= ext auth > +# 'vencrypt+x509+none' if VEncrypt is used with x509 and no aut= h > +# 'vencrypt+x509+vnc' if VEncrypt is used with x509 and VNC aut= h > +# 'vencrypt+x509+plain' if VEncrypt is used with x509 and plain= text auth > +# 'vencrypt+tls+sasl' if VEncrypt is used with TLS and SASL aut= h > +# 'vencrypt+x509+sasl' if VEncrypt is used with x509 and SASL a= uth This feels like an open-coded string that should instead be an array of enum values. That is, { 'enum': 'VncAuth', 'data', [ 'none', 'vnc', 'vencrypt', 'plain', 'tls', 'x509' ] } =2E.. 'auth': ['VcnAuth'] might be friendlier to applications (having to post-parse the '+' is not friendly). > +# > +# @display: #optional The display device the vnc server is linked to. > +# > +# Since: 2.3 > +## > +{ 'type': 'VncInfo2', > + 'data': { 'id' : 'str', > + 'server' : ['VncBasicInfo'], > + 'clients' : ['VncClientInfo'], > + 'auth' : 'str', > + '*display' : 'str' } } Looks reasonable, other than my concern about 'auth'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4DGj1ikvNrt8SD4KWgvJ4RqnPt4bn2VAa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUiHo1AAoJEKeha0olJ0NqR+AH/RnBtXlgjmpAedKqiB/4RYS8 nWOzWd7KDF9hfNcWvLurIxHeB0U6VZXoANVqH/wtrCmy2fNFBzwoA8yNbFbisOSR t8g+3/O1iM1TYGVPHuUv2zxSACRCQUhT979qyaOyYxfkWGjYWHvNUQzChPwjPX/n /77trlC1i47auDvClbi7RCQ5UdcGpjezLbfmWT8wnldCqmqB71rP3O7aMB0E+0yz 5A+NjBaUnYwRZkagqVT8sbCvR2RGoG8MR6gHnREhm1Aw8arMP8FFVzpqAFmpgc39 fkmbeedZ5XdubU3pblawgWIn0WkaGek7nJEmvGi/gxdyw1C9JqG4joHvo2EA88Y= =hKE4 -----END PGP SIGNATURE----- --4DGj1ikvNrt8SD4KWgvJ4RqnPt4bn2VAa--