Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On 12/10/2014 02:37 AM, Gerd Hoffmann wrote:
> Add websockets bool to VncBasicInfo, report websocket server sockets,
> flag websocket client connections.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qapi-schema.json |  5 ++++-
>  ui/vnc.c         | 14 ++++++++++++--
>  2 files changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 677a762..a945693 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -672,12 +672,15 @@
>  #
>  # @family: address family
>  #
> +# @websocket: #optional true in case the socket is a websocket (since 2.2).

s/2.2/2.3/

> +#
>  # Since: 2.1
>  ##
>  { 'type': 'VncBasicInfo',
>    'data': { 'host': 'str',
>              'service': 'str',
> -            'family': 'NetworkAddressFamily' } }
> +            'family': 'NetworkAddressFamily',
> +            '*websocket': 'bool' } }

Is it optional because you omit it when false?  Why not just always
output the bool, so that clients know they are talking to a new-enough
qemu that knows about websockets (and this is explicitly not one), vs.
having to guess that the omission of the bool implies that it is not
rather than being an older qemu.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]