From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XykX0-00068h-BW for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:54:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XykWu-0000vj-QB for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:54:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XykWu-0000vP-I9 for qemu-devel@nongnu.org; Wed, 10 Dec 2014 11:54:24 -0500 Message-ID: <54887ABB.6090605@redhat.com> Date: Wed, 10 Dec 2014 09:54:19 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1418204253-5869-11-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6UXOSxCBLTVpddNqM6B5puAPxr3nVtNH0" Subject: Re: [Qemu-devel] [PATCH v2 10/10] monitor: add vnc websockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Markus Armbruster , Anthony Liguori , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6UXOSxCBLTVpddNqM6B5puAPxr3nVtNH0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/10/2014 02:37 AM, Gerd Hoffmann wrote: > Add websockets bool to VncBasicInfo, report websocket server sockets, > flag websocket client connections. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 5 ++++- > ui/vnc.c | 14 ++++++++++++-- > 2 files changed, 16 insertions(+), 3 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 677a762..a945693 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -672,12 +672,15 @@ > # > # @family: address family > # > +# @websocket: #optional true in case the socket is a websocket (since = 2.2). s/2.2/2.3/ > +# > # Since: 2.1 > ## > { 'type': 'VncBasicInfo', > 'data': { 'host': 'str', > 'service': 'str', > - 'family': 'NetworkAddressFamily' } } > + 'family': 'NetworkAddressFamily', > + '*websocket': 'bool' } } Is it optional because you omit it when false? Why not just always output the bool, so that clients know they are talking to a new-enough qemu that knows about websockets (and this is explicitly not one), vs. having to guess that the omission of the bool implies that it is not rather than being an older qemu. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6UXOSxCBLTVpddNqM6B5puAPxr3nVtNH0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUiHq7AAoJEKeha0olJ0NqNqQIAJCcs7z6GHPIaMMfn6pI2S8Y PiHy+gtdO3FnNZYDFx+S4NC1BYtDrmyOGTkY+9vrDIwTuqzjyBVl/egyRpWQV2JL 4XopT0e7m3EUXk/zi7bq3LCM9AFFYMM/Ar9tt9OMsIdvpRVxrAIkGvWfIVcJlnzq vJiFXUrQlICoAktkFqDWU4PRqCwO24VK0+sphCWJQBHOHfaj9pavY/yAJ1VwzsXY z66d3DM4vJI45Hz877enSc8QEhSelkLXTy+LY4+ZSu7Y4LYEhf8g8/6NitiZyy0V cOecuDC2vJ7yYGpnnVKspgh8KTOTpm4UWAe4ZSC6Gvugyj9dUXdkBDAV1tlhcIs= =XYou -----END PGP SIGNATURE----- --6UXOSxCBLTVpddNqM6B5puAPxr3nVtNH0--