From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylKj-0000BN-0v for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XylKd-0002OC-7S for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylKc-0002Nz-Pm for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:45:47 -0500 Message-ID: <54887D94.2050501@redhat.com> Date: Wed, 10 Dec 2014 10:06:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <20141210162317.370733848@amt.cnet> <20141210162420.218207164@amt.cnet> In-Reply-To: <20141210162420.218207164@amt.cnet> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4CaNPXdd9ILEGKTUsE90JwgHKP0oGmvVK" Subject: Re: [Qemu-devel] [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org Cc: Paolo Bonzini , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4CaNPXdd9ILEGKTUsE90JwgHKP0oGmvVK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/10/2014 09:23 AM, Marcelo Tosatti wrote: > Add machine option and QMP commands to configure TSC deadline > timer advancement. >=20 > Signed-off-by: Marcelo Tosatti >=20 > --- > +## > +# @get-lapic-tscdeadline-advance > +# > +# This command gets the TSC deadline timer advancement. > +# > +# Only supported by KVM acceleration. > +# > +# Since: 2.3 > +## > +{ 'command': 'get-lapic-tscdeadline-advance', 'returns': 'int' } Please don't return a bare int. It is not extensible, if we ever need multiple named values associated with lapic in the future. Return a dictionary instead. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4CaNPXdd9ILEGKTUsE90JwgHKP0oGmvVK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUiH2UAAoJEKeha0olJ0NqLKcIAIgNIfG0zbxZhXA1wcfFlGKw 432gWJPXww6ztaZskJ8Icm63P0dxk/9s6cvwD1MASp3tQAhGlLQctczO11VoftsW obE0qVbT3xfqbQL8hyMKDxWyU+6UfJ1HJJz9SfvmPbx8CGRynuatrqCdka9Q4ocN z27G0dw1k9CkSYpKnh1Aj6bu/h0xVOBdPYBCFq+Mut4wMWSz6y9PtD/AKHJbchvX c3v/Rm4z/V8SENLTIaWhTMeMZPp4Tw9uHGLrlD02BI/X/ITk9FySuM0KZCdnfH7Z B7Zr7cWcjVD4x1q1VLYPw9oIPqlR0bOaPY9n0XJNrFI0gU9sSJSW6RzhCPdqRi4= =fIKS -----END PGP SIGNATURE----- --4CaNPXdd9ILEGKTUsE90JwgHKP0oGmvVK--