From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XymUZ-00085M-Vs for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:00:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XymUQ-0005th-VZ for qemu-devel@nongnu.org; Wed, 10 Dec 2014 14:00:07 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:42235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XymUQ-0005sh-PM for qemu-devel@nongnu.org; Wed, 10 Dec 2014 13:59:58 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so6220451wiw.9 for ; Wed, 10 Dec 2014 10:59:58 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54889829.7090604@redhat.com> Date: Wed, 10 Dec 2014 19:59:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20141210162317.370733848@amt.cnet> <20141210162420.218207164@amt.cnet> <54887C61.80008@redhat.com> <20141210170405.GA19952@amt.cnet> <54887E3F.4030904@redhat.com> <20141210172712.GA20568@amt.cnet> <54888307.6020407@redhat.com> <20141210173554.GB21295@amt.cnet> <5488892C.7010606@redhat.com> <20141210183905.GA31236@potion.brq.redhat.com> In-Reply-To: <20141210183905.GA31236@potion.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [QEMU patch 2/2] kvm: allow configuration of tsc deadline timer advancement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Luiz Capitulino On 10/12/2014 19:39, Radim Krčmář wrote: > 2014-12-10 18:55+0100, Paolo Bonzini: >> Well, my preferred choice would be automatic adjustment with a module >> parameter. If we need manual tuning, per-CPU would be my choice, but >> automatic is nicer anyway. :) > > I agree with Paolo, and think it would be better not to touch QEMU ... > it makes little sense to migrate this value and it is probably going to > be quite similar on every CPU, so a writeable module parameter is a > better starting point. (We can always turn it into a nightmare later.) Ok, let's start with a simple module parameter, similar to what PLE used to have. We can use that to play with kvm-unit-tests. Paolo